Using Weld with Browserify throws error on require('tty') about weld HOT 15 CLOSED

We can do a check on the window but that's not always safe..

  if (typeof window === 'undefined') {
    nodejs = true;
  }

from weld.

a try catch around https://github.com/hij1nx/weld/blob/master/lib/weld.js#L61-64 should do the trick, you up to it?

from weld.

Tried that but didn't work. Still throws that error for some reason... Think it's something in Browserify that forces the error.

(might be doing something wrong as I am still a beginner with Node.js)

Could ask Substack to change Browserify so it allows for try/catch

from weld.

try this syntax exactly:

(require)("weld")

from weld.

Same error even with that syntax...

var weld = (require)("weld").weld;

from weld.

I figured this out, should have a patch pretty quick.

from weld.

We need this patch in Nodejitsu admin for some secret stuff ;) Current implementation is breaking stuff and I have to jump through some hoops to get it running in production.

Could you patch this in the NPM module?

from weld.

im not sure exactly what are you talking about, can you gist the patch you need?

from weld.

  if (typeof require !== 'undefined') {
    var tty = require('tty');
    if (tty.isatty && tty.isatty(0)) { 
      // if this is still a browser, they are trying really hard.
      nodejs = true;
    }
  }

This does not work in the browser because browserify does not allow require('tty'). So instead I am using a very simple check:

if (typeof window !== 'undefined') nodejs = true;

from weld.

hey, any update on a patch for this yet? Whats the best workaround in the mean time to get this working in browserify? The problem is checking for require doesn't discriminate between server/client when running a script loader such as browserify.

from weld.

this is fixed in 76b9821

from weld.

Hmm, Its not fixed. Still getting the Error: No wrapper for core module tty message when requiring it through browserify.

Thanks

from weld.

@tmpvar hey, you overwrote my fix with your fix, so im assuming your fix must have been better than mine =) looks like it didn't get tested completely?

from weld.

which one of your commits did I overwrite?

from weld.

i cant remember, but the idea i had for checking against node was...

(process && process.title === 'node')

from weld.