Giter VIP home page Giter VIP logo

Comments (3)

bruno- avatar bruno- commented on August 17, 2024 3

Hi, I hope this won't sadden anyone but in general I'm not in favor of this. grep performance is not critical to this plugin.

The speed / slowness comes mostly from bash and sending commands to tmux.

from tmux-copycat.

therealpxc avatar therealpxc commented on August 17, 2024

I can anticipate some concerns about portability, but I can imagine that this might have some performance benefits, given rg's performance in general.

I always have ripgrep installed on all of my systems, so I decided to give it a try. The only really tricky piece is that rg always uses extended regular expressions, so there are two changes required besides substituting rg for grep.

If you'd like to try the ripgrep version you can just uninstall tmux-plugins/tmux-copycat and then install therealpxc/tmux-copycat (I'm not sure that just replacing one with the other and reloading tmux will work right.).

If someone would like to write up some performance tests so that we can more objectively identify how much improvement there is, if any, that would be great.

@BogBel, I think it would be really helpful for this issue if you could expand the title and description to make it clear why someone might want this change, why it should be considered safe, etc.

I think that if we just modify the patterns to assume extended regular expressions, so that tmux-copycat can prefer rg but instead use grep -E when it is available, we can add preferential ripgrep support and retain the relative portability that tmux-copycat currently enjoys.

Is there any developer interest in merging such changes? I'm happy to open up a pull request for further discussion if so.

from tmux-copycat.

alphaCTzo7G avatar alphaCTzo7G commented on August 17, 2024

Actually I agree.. rg might be a bit of a overkill here.. Also are we using basic regular expressions or extended regular expressions here?

from tmux-copycat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.