Comments (4)
tobie
commented on July 29, 2024
Standardizing on a attribut names is fine. It's also easy to keep the previous ones around for backwards compat purposes.
I don't have a strong feeling about your second point other than that it shouldn't delay merging the projects.
from ua-parser.
elsigh
commented on July 29, 2024
I don't actually mind that much if we don't standardize property names or what the parsers do. Sure, it seems like that would be a nice touch, but it's not a requirement. I don't think the JS parser does v2 or v3 fwiw.
I'm with Tobie on point #2 as well. My hunch is that you need things added things to regexes.yaml to support this, and I'm good with that.
from ua-parser.
tobie
commented on July 29, 2024
The JS parser does support v1 and v2, it just calls them minor and patch (after SemVer).
from ua-parser.
tobie
commented on July 29, 2024
Closing this and opening separate issues for what still needs to get done.
from ua-parser.
Related Issues (20)
- isMobile alternative HOT 2
- Desktop browsers return as Other. HOT 11
- Wrong detection of Amazon Silk HOT 3
- Publish the Java Maven artifact in the maven central repository HOT 3
- ua_parser:pig
- Outlook UA strings
- Linux Mint 17.2 is reported as linux mint 17 HOT 1
- Edge Browser not detected HOT 4
- Device family is not getting parsed properly HOT 2
- Node js upgradation
- uap-lua HOT 1
- Case sensitive regex match in C# uaparser HOT 1
- used in hive udf gives IOException HOT 1
- unit test error HOT 1
- Convert the .net project to a portable project so i can target more platforms
- Tests fail in Java Directory with the lastest regexes.yaml
- Mobile BingBot detected as iPhone HOT 1
- Regex expressions for web application scanners HOT 1
- ua_dict missing data raises: exceptions.TypeError: parse_device() takes exactly 3 arguments (1 given)
- regex place holder is not working in regex_yaml HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ua-parser.