request "repo rollback" command about git-repo HOT 2 OPEN

Comment by Shawn Pearce <[email protected]> on Tue May 26 15:07:29 PDT 2009

*sigh*, I have no idea what server 3054 is on that you are talking about.

But besides that.

You should use the commit SHA-1 next to the default expanded patch set for the
change.  E.g. consider if change https://review.source.android.com/10019 was
submitted.  To revert this, we would need to issue `git revert
86b5102f54caa80e51a3b8c5ec8c4f5bcb4f6c57` as 86b510... is the SHA-1 for patch
set 4, which is the current patch set.

Right now I'm slightly negative on adding any new functionality to repo if it
isn't in the critical day-to-day workflow path of several thousand people.
Everyone wants cake, wants to have it on their desk, wants to eat it, and
wants a pony delivered in the corner of the room, to ride to that meeting they
really don't want to be in later today.  Adding new commands to an existing
mess is only going to make matters worse, not better.  E.g. "repo download"
currently has broken semantics because you can't use "repo download" from the
external review.source.android.com server to download to something based on a
private company mirror.  "repo rollback" as you propose as a similar problem.
Its also likely that GERRIT-175 will make matters worse here, not better, as
it moves a whole slew of the change number -> commit SHA-1 mapping data into
archive repositories.