Giter VIP home page Giter VIP logo

Comments (4)

affine-bot avatar affine-bot commented on June 2, 2024

Hello! Thank you for filing an issue.
If this is a bug report, please include relevant logs to help us debug the problem.

from octobase.

darkskygit avatar darkskygit commented on June 2, 2024

thank you for discovering this bug, we are currently moving the features related to affine cloud in this repo to: https://github.com/toeverything/AFFiNE/tree/master/apps/server , this allows this repo to focus more on implementing crdt based database.

however, we will keep a example project for this project about sync and storage feature, and the logic related to the database connection will remain, so your pr is welcome!

from octobase.

olivierIllogika avatar olivierIllogika commented on June 2, 2024

Thank you for the info @darkskygit

I was led to OctoBase from AFFiNE contributing tutorial; my understanding was that the AFFiNE backend was this OctoBase repo.

As for this bug, I would gladly submit a PR, but I don't understand the use of the storage variable / _binary database in context.rs; I was just trying to make this work. I think my documented investigation might be useful to others for now.

from octobase.

darkskygit avatar darkskygit commented on June 2, 2024

Thank you for the info @darkskygit

I was led to OctoBase from AFFiNE contributing tutorial; my understanding was that the AFFiNE backend was this OctoBase repo.

As for this bug, I would gladly submit a PR, but I don't understand the use of the storage variable / _binary database in context.rs; I was just trying to make this work. I think my documented investigation might be useful to others for now.

sorry, i re-reviewed the code. the mentioned behavior of adding _binary as a database prefix is a specific implementation of the cloud server. jwst-storage (the library that actually handles workspace and binary storage) can accept any supported database connection.

the server project that will be used to demonstrate OctoBase functionality in the future will not need to contain this specific implementation, so I don't think any further fixes will be needed (since we already have a new server rewritten based on OctoBase in the AFFiNE repository).

thank you very much for your enthusiasm towards our project. I welcome you to raise other issues or submit pull requests for existing issues.

from octobase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.