Comments (9)
I think probe.is_supported()
accepts opcode instead of syscall. so we just need probe.is_supported(Openat2::CODE)
.
from io-uring.
The sys
mod module is generated using bindgen, and it often breaks API compatibility. so it is unlikely to be made public directly.
But I am willing to put it behind internal
feature gate.
from io-uring.
Yes a feature gate sounds fine to me.
But one question though, how do you expect something like probe.is_supported()
to be used? Or even when you want to refer to the syscall since they're not part of libc yet?
from io-uring.
Oh yes I missed the CODE
defined for each opcode!
The syscall is for another use case I have. Since I want to use seccomp
, I need to refer the syscall number, and I would have preferred to rely on the crate rather than having to define it (again) myself.
from io-uring.
I think we can export them in a stable way from sys
mod. It is only necessary to ensure that no accidental API breakage occurs.
from io-uring.
We can have a syscall
mod and put __NR_io_uring_register
and other things in it. but I am not sure if this is necessary, I expect them to enter libc in the future.
Maybe an internal
feature gate is enough, because we can expect the syscall API will not be changed.
from io-uring.
Yes I agree the internal feature gate is maybe the easiest way to go, as we can expect libc will soon expose these syscalls, and so you would remove the internal feature gate once this happens.
from io-uring.
The syscalls seem to be in libc
already. You probably want to update the libc crate too, since the bindgen definition of the syscall number is wrong for mips and mips64.
from io-uring.
Great, I will switch to the definition of libc.
from io-uring.
Related Issues (20)
- missing multishot commands HOT 9
- missing opcode PollUpdate
- opcode::Recv , buf_group and multi question HOT 2
- open question about race with kernel that liburing had to fix HOT 1
- ffi::CString crash help HOT 9
- opcode Read misses IOSQE_BUFFER_SELECT flag? HOT 4
- Is it possible to use opcode::Accept with types::Fixed? HOT 3
- Consider derive Eq for DestinationSlot
- feature wanted: io_uring_submit_and_wait_timeout HOT 2
- Socket test fails on master HOT 4
- `Waking up` io-uring question HOT 1
- To set `nonblocking`-mode on streams or not? HOT 1
- After `SendZc` submission sender receives two messages HOT 2
- `SendToZc` implemetation HOT 1
- Expose access to user_data of squeue::Entry
- Help with timed events on a event loop structure
- Add changelog file HOT 1
- Building with bindgen feature fails with recent kernel headers. HOT 1
- Docs for `Read` opcode talk about setting `offset` to `-1`, yet `offset: u64` HOT 3
- Should `SubmissionQueue::push()` also check for `cq_overflow()`? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from io-uring.