I tried to use io_uring statx but fail with errno 22. The same parameters can run succ

I added a test on statx. <div class="Box-h

io_uring statx doesn't work about io-uring HOT 4 CLOSED

tokio-rs commented on June 7, 2024

io_uring statx doesn't work

from io-uring.

Comments (4)

quininer commented on June 7, 2024

I have not been able to reproduce the problem, can you provide the code to reproduce it?

from io-uring.

quininer commented on June 7, 2024

I added a test on statx.

io-uring/io-uring-test/src/tests/fs.rs

Lines 276 to 356 in ef2b1ee

 pub fn test_statx(ring: &mut IoUring, test: &Test) -> anyhow::Result<()> { 

 require!( 

 test; 

 test.probe.is_supported(opcode::Statx::CODE); 

 ); 

 println!("test statx"); 

 let dir = tempfile::tempdir()?; 

 let path = dir.path().join("test-io-uring-statx"); 

 let pathbuf = CString::new(path.as_os_str().as_bytes())?; 

 fs::write(&path, "1")?; 

 let mut statxbuf: libc::statx = unsafe { std::mem::zeroed() }; 

 let statx_e = opcode::Statx::new( 

 types::Fd(libc::AT_FDCWD), 

 pathbuf.as_ptr(), 

 &mut statxbuf as *mut libc::statx as *mut _, 

 ) 

 .mask(libc::STATX_ALL) 

 .build() 

 .user_data(0x99); 

 unsafe { 

 ring.submission().push(&statx_e).expect("queue is full"); 

 } 

 ring.submit_and_wait(1)?; 

 let cqes = ring.completion().collect::<Vec<_>>(); 

 assert_eq!(cqes.len(), 1); 

 assert_eq!(cqes[0].user_data(), 0x99); 

 assert_eq!(cqes[0].result(), 0); 

 // check 

 let mut statxbuf2 = unsafe { std::mem::zeroed() }; 

 let ret = unsafe { 

 libc::statx( 

 libc::AT_FDCWD, 

 pathbuf.as_ptr(), 

 0, 

 libc::STATX_ALL, 

 &mut statxbuf2, 

 ) 

 }; 

 assert_eq!(ret, 0); 

 assert_eq!(statxbuf, statxbuf2); 

 // statx fd 

 let fd = fs::File::open(&path)?; 

 let mut statxbuf3: libc::statx = unsafe { std::mem::zeroed() }; 

 let statx_e = opcode::Statx::new( 

 types::Fd(fd.as_raw_fd()), 

 b"\0".as_ptr().cast(), 

 &mut statxbuf3 as *mut libc::statx as *mut _, 

 ) 

 .flags(libc::AT_EMPTY_PATH) 

 .mask(libc::STATX_ALL) 

 .build() 

 .user_data(0x9a); 

 unsafe { 

 ring.submission().push(&statx_e).expect("queue is full"); 

 } 

 ring.submit_and_wait(1)?; 

 let cqes = ring.completion().collect::<Vec<_>>(); 

 assert_eq!(cqes.len(), 1); 

 assert_eq!(cqes[0].user_data(), 0x9a); 

 assert_eq!(cqes[0].result(), 0); 

 assert_eq!(statxbuf3, statxbuf2); 

 Ok(()) 

 }

from io-uring.

sunyulin728 commented on June 7, 2024

I think it is my code problem. I will dig into it.

BTW: When I run the test code, I got following error message.

assert_eq!(statxbuf, statxbuf2);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ libc::statx cannot be formatted using {:?} because it doesn't implement Debug
|
= help: the trait Debug is not implemented for libc::statx

from io-uring.

quininer commented on June 7, 2024

You need to manually turn on the extra_traits feature of libc.

from io-uring.

io_uring statx doesn't work about io-uring HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub fn test_statx(ring: &mut IoUring, test: &Test) -> anyhow::Result<()> {
	require!(
	test;
	test.probe.is_supported(opcode::Statx::CODE);
	);

	println!("test statx");

	let dir = tempfile::tempdir()?;
	let path = dir.path().join("test-io-uring-statx");
	let pathbuf = CString::new(path.as_os_str().as_bytes())?;
	fs::write(&path, "1")?;

	let mut statxbuf: libc::statx = unsafe { std::mem::zeroed() };

	let statx_e = opcode::Statx::new(
	types::Fd(libc::AT_FDCWD),
	pathbuf.as_ptr(),
	&mut statxbuf as mut libc::statx as mut _,
	)
	.mask(libc::STATX_ALL)
	.build()
	.user_data(0x99);

	unsafe {
	ring.submission().push(&statx_e).expect("queue is full");
	}

	ring.submit_and_wait(1)?;

	let cqes = ring.completion().collect::<Vec<_>>();

	assert_eq!(cqes.len(), 1);
	assert_eq!(cqes[0].user_data(), 0x99);
	assert_eq!(cqes[0].result(), 0);

	// check
	let mut statxbuf2 = unsafe { std::mem::zeroed() };
	let ret = unsafe {
	libc::statx(
	libc::AT_FDCWD,
	pathbuf.as_ptr(),
	0,
	libc::STATX_ALL,
	&mut statxbuf2,
	)
	};

	assert_eq!(ret, 0);
	assert_eq!(statxbuf, statxbuf2);

	// statx fd
	let fd = fs::File::open(&path)?;
	let mut statxbuf3: libc::statx = unsafe { std::mem::zeroed() };

	let statx_e = opcode::Statx::new(
	types::Fd(fd.as_raw_fd()),
	b"\0".as_ptr().cast(),
	&mut statxbuf3 as mut libc::statx as mut _,
	)
	.flags(libc::AT_EMPTY_PATH)
	.mask(libc::STATX_ALL)
	.build()
	.user_data(0x9a);

	unsafe {
	ring.submission().push(&statx_e).expect("queue is full");
	}

	ring.submit_and_wait(1)?;

	let cqes = ring.completion().collect::<Vec<_>>();

	assert_eq!(cqes.len(), 1);
	assert_eq!(cqes[0].user_data(), 0x9a);
	assert_eq!(cqes[0].result(), 0);

	assert_eq!(statxbuf3, statxbuf2);

	Ok(())
	}