Giter VIP home page Giter VIP logo

Comments (6)

carllerche avatar carllerche commented on June 15, 2024 1

I have been running the reproduction using the PR linked above and memory is stable for me.

from mini-redis.

Darksonn avatar Darksonn commented on June 15, 2024

If you modify Tokio to print when Arc<WaitNode> is created and dropped inside broadcast, you will see that it creates one for every connection, but none of them are dropped until the application closes.

from mini-redis.

carllerche avatar carllerche commented on June 15, 2024

Thanks for the report. I will try to look later today. My guess, w/o looking, is that it is a similar problem as the old semaphore had. If that is a case, it will need a similar rework as tokio-rs/tokio#2325

from mini-redis.

hawkw avatar hawkw commented on June 15, 2024

@carllerche do you think broadcast can easily be modified to use the semaphore?

from mini-redis.

carllerche avatar carllerche commented on June 15, 2024

Open PR here: tokio-rs/tokio#2509

from mini-redis.

carllerche avatar carllerche commented on June 15, 2024

Fixed w/ the tokio release.

from mini-redis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.