Audit code for unbounded growth vectors about tokio-core HOT 4 OPEN

Some known locations:

• Sender::send
• Handle::send

The Handle::send method transitively affects quite a few locations, however.

from tokio-core.

While playing with the echo server example, I've noticed that if you feed the server with something like cat /dev/urandom | nc 127.0.0.1 12345 it just buffers the input until EOF (which can quite quickly fill up Gbs of ram) never calling the decode method of Codec before the EOF.

I think this is caused by the use of read_to_end in Framed : https://github.com/tokio-rs/tokio-core/blob/master/src/io/frame.rs#L305.

from tokio-core.

@mdevlamynck oh good point! Note though that it stops as soon as it hits "would block", so it doesn't always wait for EOF. That being said though it'd still be great to fix that TODO

from tokio-core.

@mdevlamynck I created #153 to track your issue. The issue isn't really captured by this one.

from tokio-core.