Giter VIP home page Giter VIP logo

Comments (5)

samschlegel avatar samschlegel commented on July 17, 2024 2

👋 Dropping a line here in reference to a convo in the #tracing channel in Discord.

Currently we use slog in a bunch of our libs/services which has a syntax like

info!(logger, "msg: {}", 1, formatted_field="a"; "additional_field" => 4)

The fields before the ; are used for the format string, and the result of that is used as msg in the json output. The fields after are just added to the json directly.

I'm not actually a huge fan of this, mostly cause it leads to duplication of fields, and the syntax differs between then in a weird wait. Something that might be nice could be if the syntax was basically just like format!/println! but it didn't error when named arguments weren't used, and all named arguments were added as fields, but I haven't totally thought through the implications of that. Like I'm not sure how field = ?value would work if the field was used multiple times, and say we wanted it to be Display in the span/event fields, but Debug in the message

from tracing.

hawkw avatar hawkw commented on July 17, 2024

I suspect it should be possible to add syntax for interpolating fields into a textual message in tokio-trace's current macros. May just require some thought to make work.

from tracing.

Ralith avatar Ralith commented on July 17, 2024

Since Rust RFC 2795 will be stabilized in 1.58, the ergonomic semantics outlined by @samschlegel above should soon be achievable. All we'll need to do is modify event! and span! to interpret format arguments as fields, and use implicit format argument captures for them so that unused fields do not become an error.

from tracing.

CryoMyst avatar CryoMyst commented on July 17, 2024

Is there anything currently blocking this feature from happening?

from tracing.

Ralith avatar Ralith commented on July 17, 2024

No, it's fairly straightforwardly doable now, just nobody's had time to get to it.

from tracing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.