Comments (5)
👋 Dropping a line here in reference to a convo in the #tracing channel in Discord.
Currently we use slog
in a bunch of our libs/services which has a syntax like
info!(logger, "msg: {}", 1, formatted_field="a"; "additional_field" => 4)
The fields before the ; are used for the format string, and the result of that is used as msg
in the json output. The fields after are just added to the json directly.
I'm not actually a huge fan of this, mostly cause it leads to duplication of fields, and the syntax differs between then in a weird wait. Something that might be nice could be if the syntax was basically just like format!/println!
but it didn't error when named arguments weren't used, and all named arguments were added as fields, but I haven't totally thought through the implications of that. Like I'm not sure how field = ?value
would work if the field was used multiple times, and say we wanted it to be Display in the span/event fields, but Debug in the message
from tracing.
I suspect it should be possible to add syntax for interpolating fields into a textual message in tokio-trace
's current macros. May just require some thought to make work.
from tracing.
Since Rust RFC 2795 will be stabilized in 1.58, the ergonomic semantics outlined by @samschlegel above should soon be achievable. All we'll need to do is modify event!
and span!
to interpret format arguments as fields, and use implicit format argument captures for them so that unused fields do not become an error.
from tracing.
Is there anything currently blocking this feature from happening?
from tracing.
No, it's fairly straightforwardly doable now, just nobody's had time to get to it.
from tracing.
Related Issues (20)
- `tracing::instrument(ret)` errors on function with `&mut` args returning `&`/`&mut` HOT 2
- tracing_appender with_max_level error when using with NonBlockingBuilder finish
- Please support `Instrument` on types implementing `IntoFuture ` HOT 1
- tracing-subscriber: `Filtered` does not respect global filters properly
- Enable overriding `target` field with `log`'s target in `LogTracer` HOT 1
- Should crate documentation call out that non-blocking writers are lossy by default? HOT 2
- Tried to drop a ref to Id(3), but no such span exists!
- Exaustiveness checking for LevelInner leaks through public API HOT 1
- Incorrect `Interest::Never` is cached and never invalidated on v0.1
- instrument triggers clippy::blocks_in_conditions HOT 2
- Sifting layer, decide what writer to use on the fly
- Event macros not behaving as expected with more complex message formatting with filter layers HOT 5
- [Tracing][Subscriber] Extend root fields with (static) custom fields
- Doc links broken in instrument documentation HOT 1
- Context docs in tracing-subscriber reference scope method that does not exist
- Type erasure for registry/subscribers HOT 2
- Docs: tracing field names CAN actually have a dot in them now
- Better support for dynamically adjusting the filter
- Bug: In some scenarios, log content is lost. HOT 2
- SubscriberInitExt trait method set_default doesn't work well during bootstrap with feature tracing-log on
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tracing.