Giter VIP home page Giter VIP logo

Comments (8)

hawkw avatar hawkw commented on August 16, 2024

I've tried to provide a thorough description of how I would recommend making this change, so it should be appropriate for a new contributor. With that said, if anyone's interested in working on this one and anything I said above is confusing or unclear, please let me know and I'm happy to explain further.

from tracing.

zaharidichev avatar zaharidichev commented on August 16, 2024

@hawkw May be wrong on that, but it seems to me that in order to implement Event::child_of(...) the same way as Span::child_of ,the AsId type needs to be moved from tokio-trace to tokio-trace-core in order to be visible there. Correct me if I am wrong :)

from tracing.

hawkw avatar hawkw commented on August 16, 2024

@zaharidichev that's a good point, thanks --- I think I overlooked that. I'd actually like to look into removing the AsId trait in the upcoming release, as I think it can be replaced with Into implementations. So, that may be the best solution.

from tracing.

zaharidichev avatar zaharidichev commented on August 16, 2024

Wouldn’t that introduce a breaking change though ?

from tracing.

hawkw avatar hawkw commented on August 16, 2024

Yes. There are other unavoidable breaking changes scheduled for a tokio-trace 0.2 release, though, so now would be a good time to make that change as well.

from tracing.

hawkw avatar hawkw commented on August 16, 2024

@zaharidichev see also #1102 :)

from tracing.

zaharidichev avatar zaharidichev commented on August 16, 2024

Great, I already started on this one and will rebase once #1102 is merged. Will be able to pick it back up in the following days though. Someone might beat me to it by then :)

from tracing.

hawkw avatar hawkw commented on August 16, 2024

This was closed by tokio-rs/tokio#1109.

from tracing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.