Comments (8)
I've tried to provide a thorough description of how I would recommend making this change, so it should be appropriate for a new contributor. With that said, if anyone's interested in working on this one and anything I said above is confusing or unclear, please let me know and I'm happy to explain further.
from tracing.
@hawkw May be wrong on that, but it seems to me that in order to implement Event::child_of(...)
the same way as Span::child_of
,the AsId
type needs to be moved from tokio-trace to tokio-trace-core in order to be visible there. Correct me if I am wrong :)
from tracing.
@zaharidichev that's a good point, thanks --- I think I overlooked that. I'd actually like to look into removing the AsId
trait in the upcoming release, as I think it can be replaced with Into
implementations. So, that may be the best solution.
from tracing.
Wouldn’t that introduce a breaking change though ?
from tracing.
Yes. There are other unavoidable breaking changes scheduled for a tokio-trace
0.2 release, though, so now would be a good time to make that change as well.
from tracing.
@zaharidichev see also #1102 :)
from tracing.
Great, I already started on this one and will rebase once #1102 is merged. Will be able to pick it back up in the following days though. Someone might beat me to it by then :)
from tracing.
This was closed by tokio-rs/tokio#1109.
from tracing.
Related Issues (20)
- Make method env_var_name public HOT 1
- Broken link in documentation. HOT 2
- [tracing_subscriber::filter::Builder] Proposal for supporting multiple default directives / setting a default filter
- Unqualified `line!` macro usage inside `info!` causes issues with `ratatui_macros` HOT 1
- How to modify EnvFilter instead of replace HOT 3
- RollingFileAppender `prune_old_logs()` relies on `metadata().created()` which is not available on all platforms HOT 1
- Make Layer::with_writer not truncate the file HOT 4
- When will the feature(`valuable` suport`) be merged into stable version? HOT 1
- error[E0609]: no field `free` on type `REGISTRY` HOT 3
- Add an option for outputting span IDs HOT 1
- RollingFileAppender: prefix and suffix custom separator
- `#instrument` attribute not making new spans HOT 2
- Execute custom code every time `error!` (etc) is called HOT 4
- Make path clickable HOT 2
- Lacking documentation of context propagation through channels HOT 2
- `fn subscriber` did exist in the main branch, but not in `tracing-subscriber-0.3.18` HOT 2
- Valuable: Enum Representations
- JSON: Field names should account for `r#` HOT 4
- Inconsistent behaviour in tracing_subscriber wrt tracing_log HOT 6
- Allow `Display` formatting of `Option`s in messages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tracing.