Giter VIP home page Giter VIP logo

Comments (3)

tolu avatar tolu commented on July 24, 2024 1

That should have been adressed by #34 but if you find any other situations that are not accounted for please provide an example of feel free to add a PR 🙏

from iso8601-duration.

bumblebot1 avatar bumblebot1 commented on July 24, 2024 1

Thank you, it looks like that commit has solved the issue.

I was using this example to reproduce it in version 2.1.1 of the library (before that commit):

let start = new Date("2023-10-29T02:00:00.000+01:00")
result = module.toSeconds({minutes:5}, second)
// value of result would be -3300

With version 2.1.2 of the library (which includes that commit) the result returned is correct:

let start = new Date("2023-10-29T02:00:00.000+01:00")
result = module.toSeconds({minutes:5}, second)
// value of result would be 300

from iso8601-duration.

tolu avatar tolu commented on July 24, 2024

it should be easy to provide an example where this module produces a different result than the @js-temporal/polyfill that I test against to ensure compliance. If so then there is absolutely a bug in this module.

from iso8601-duration.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.