Comments (1)
This was pretty tricky to fix! I eventually traced it back to a couple of bugs. If the input stream ends with an identifier token, the buffer was never terminating because apparently regex.test(null) returns true, so the identifier was ending up "khnull", which obviously wouldn't match anything.
Secondly, there were a couple of key places where the parsing context was switched to parse a dice roll expression (4d6) rather than a dice expression, which includes the additional modifiers. I've fixed it, and added some regression tests as part of my latest update. So as of 1.5.0, which has been published, this should be fixed.
Thanks for your help, and let me know if you have any more trouble!
from dice-typescript.
Related Issues (16)
- Add support for in-line real numbers HOT 1
- Missing deployment instructions? HOT 1
- Package Missing TypeScript Type Declarations HOT 1
- Evaluating a bad roll expression crashes HOT 2
- Set a limit for face / dice number HOT 2
- Showing the amount kept or dropped in renderedExpression HOT 1
- Publish version 1.6.0 to NPM HOT 1
- Clarify Behavior for Fractional Dice Rolls
- Preventing infinite loops in exponding/rerolling when multiple conditions are specified
- Comment syntax interfering with rolls.
- ErrorMessage is referenced in README, but does not exist
- Add Support for Dice Modifiers HOT 1
- Add Support for Compare Points HOT 1
- Add support for repeating groups. HOT 1
- Feature Request: Be able to show the individual rolls HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dice-typescript.