If the options include a msg prefix, suffix or msg_name_to_l

I merged your fix in <a class="issue-link js-issue-link" data-error-text="Failed to lo

Prefix/suffix/lowercase crashes on oneof about gpb HOT 6 CLOSED

tomas-abrahamsson commented on July 30, 2024

Prefix/suffix/lowercase crashes on oneof

from gpb.

Comments (6)

tsloughter commented on July 30, 2024

Hm, the issue is a little more complicated than I thought.

If I have it simply skip the oneof in this function I still have an issue with both oneof and map if they use the types of other messages and a formatter like lowercase:

message A { ...}

message B { 
  oneof x {
    A f1 = 1;
  }

  map<string, A> y = 2;
}

Both of these will fail because it can't find A in a dict it looks it up in is_msgsize_known_at_generationtime.

Not sure yet where in the parser to properly format those types.

from gpb.

tomas-abrahamsson commented on July 30, 2024

For oneof, I think the following change would do it:

--- a/src/gpb_parse.yrl
+++ b/src/gpb_parse.yrl
@@ -1095,6 +1095,9 @@ prefix_suffix_fields(Prefix, Suffix, ToLower, Fields) ->
       fun(#?gpb_field{type={msg,MsgName}}=F) ->
               NewMsgName = prefix_suffix_name(Prefix, Suffix, ToLower, MsgName),
               F#?gpb_field{type={msg,NewMsgName}};
+         (#gpb_oneof{fields=Fs}=F) ->
+              Fs2 = prefix_suffix_fields(Prefix, Suffix, ToLower, Fs),
+              F#gpb_oneof{fields=Fs2};
          (#?gpb_field{}=F) ->
               F
       end,

from gpb.

tomas-abrahamsson commented on July 30, 2024

Will take a look at map<_,_>

from gpb.

tomas-abrahamsson commented on July 30, 2024

Good thing you thought about maps too. Perhaps something along these lines:

--- a/src/gpb_parse.yrl
+++ b/src/gpb_parse.yrl
@@ -1095,6 +1095,9 @@ prefix_suffix_fields(Prefix, Suffix, ToLower, Fields) ->
       fun(#?gpb_field{type={msg,MsgName}}=F) ->
               NewMsgName = prefix_suffix_name(Prefix, Suffix, ToLower, MsgName),
               F#?gpb_field{type={msg,NewMsgName}};
+         (#?gpb_field{type={map,KeyType,{msg,MsgName}}}=F) ->
+              NewMsgName = prefix_suffix_name(Prefix, Suffix, ToLower, MsgName),
+              F#?gpb_field{type={map,KeyType,{msg,NewMsgName}}};
          (#gpb_oneof{fields=Fs}=F) ->
               Fs2 = prefix_suffix_fields(Prefix, Suffix, ToLower, Fs),
               F#gpb_oneof{fields=Fs2};

from gpb.

tsloughter commented on July 30, 2024

Cool, yup, those did it, thanks!

from gpb.

tomas-abrahamsson commented on July 30, 2024

I merged your fix in #76 and just pushed it as 3.25.0. (Closing)

from gpb.

Recommend Projects