Using wavel_range with database.add_model() about species HOT 5 CLOSED

Thanks for noticing this issue! Indeed, currently wavel_range can only be used in combination with wavel_sampling. Having the option to only use wavel_range would be useful though.

from species.

Thank you! It works. Very minor suggestion: Could species print to the screen the wavelength range that will be added? I am using a script and watching the output got afraid I had somehow forgotten to change back the range and thought it would add the full spectrum again (i.e. lead to a freeze)…

from species.

The issue seems to be with wavelength not being set (before being passed to spectres.spectres(…) at model_spectra.py:338) in the case that wavel_range is not None but wavel_sampling is None, currently not explicitly covered at model_spectra.py:255 🕵️ 😉.

from species.

This has been addressed in commit d768d2f. Setting wavel_range while not setting wavel_sampling should work both with add_model and add_custom_model!

from species.

Thanks!

from species.