Giter VIP home page Giter VIP logo

Comments (5)

tomasstolker avatar tomasstolker commented on July 30, 2024 1

Thanks for noticing this issue! Indeed, currently wavel_range can only be used in combination with wavel_sampling. Having the option to only use wavel_range would be useful though.

from species.

gabrielastro avatar gabrielastro commented on July 30, 2024 1

Thank you! It works. Very minor suggestion: Could species print to the screen the wavelength range that will be added? I am using a script and watching the output got afraid I had somehow forgotten to change back the range and thought it would add the full spectrum again (i.e. lead to a freeze)…

from species.

gabrielastro avatar gabrielastro commented on July 30, 2024

The issue seems to be with wavelength not being set (before being passed to spectres.spectres(…) at model_spectra.py:338) in the case that wavel_range is not None but wavel_sampling is None, currently not explicitly covered at model_spectra.py:255 🕵️ 😉.

from species.

tomasstolker avatar tomasstolker commented on July 30, 2024

This has been addressed in commit d768d2f. Setting wavel_range while not setting wavel_sampling should work both with add_model and add_custom_model!

from species.

gabrielastro avatar gabrielastro commented on July 30, 2024

Thanks!

from species.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.