Giter VIP home page Giter VIP logo

Comments (3)

ntoljic avatar ntoljic commented on May 29, 2024 1

In case anyone stumbles across this issue, the problem was not the missing key.
The problem was that I was calling Routemaster.of(context).push('/test'); with an open navigation drawer.
Looking at the book store example I saw that in this case I have to call Navigator.pop(context).
I am not completely sure why this is required but at least I got it working. My guess is that opening/closing the navigation drawer changes the navigation stack 🤔

@tomgilder Please disregard my suggestion of adding the key to the docs, it is not actually necessary and just masked the real issue I was having.

from routemaster.

ntoljic avatar ntoljic commented on May 29, 2024

I have just realized what the culprit was.
Since I copied the sample code from the readme my MaterialPage instances did not have their key set.
Updating my routes to the following solved the issue for me:

final loginRoutes = RouteMap(
  routes: {
    '/login': (routeData) {
      print('about to return loginPage');
      return MaterialPage(ValueKey('LoginPage'), child: LoginPage());
    },
  },
  onUnknownRoute: (route, context) {
    print('redirecting to loginPage');
    return Redirect('/login');
  },
);

final routes = RouteMap(
  routes: {
    '/': (_) => MaterialPage(ValueKey('HomePage'), child: HomePage()),
    '/test': (_) => MaterialPage(ValueKey('TestPage'), child: TestPage()),
  },
  onUnknownRoute: (route, context) => MaterialPage(ValueKey('NotFoundPage'), child: NotFoundPage()),
);

Maybe the readme could be extended to mention this fact or the examples adapted?

from routemaster.

tomgilder avatar tomgilder commented on May 29, 2024

Good point, will add to the documentation 👍

Glad you got it solved, thanks!

from routemaster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.