How to add additional numbers to the ignore list? about go-mnd HOT 5 CLOSED

This feature is really essential. Without it I just have to disable the whole linter, because 1 is often used in cycles.

from go-mnd.

@vitalyisaev2
I'll release it today. :) But can you please provide an example for the case you mentioned? Maybe I can exclude it by default.

from go-mnd.

@bishtawi
It's implemented. Please checkout the new version v1.2.0 :)

from go-mnd.

Hi @bishtawi,

currently that's not possible. But that would be a nice addition. I'll implement it soon.

from go-mnd.

@tommy-muehle thanks for the quick implementation of this feature!

Regarding to the cases where 1 should not be considered as a magic number, please have a look at these snippets.

Custom for loop:

        // custom for loop
	for i, itemID := range ring {
		next := i + 1
		start := int(itemID)%ring.totalItems - 1

		if start < 0 {
			start += step
		}

                // ...

Branching based on int value evaluation:

    func computeResult(value int) ([][]int, error) {
	if subsets == 0 {
		return nil, fmt.Errorf("invalid value: 0")
	}

	if subsets == 1 {
		return [][]int{{255}}, nil
	}

       // more complicated logic for other cases

To be honest, I have no idea which name should I use for a variable or constant that will be equal to 1 in order to make it non-magic number :)

from go-mnd.