Giter VIP home page Giter VIP logo

Comments (11)

aaulia avatar aaulia commented on June 18, 2024 1

I also found this comment from another, closed, issue. Maybe it's related.

The only thing that seems to be removed is the support of other theme choices (forest/dark), but with the new default theme, perhaps I don't need other themes anymore :)

from vscode-mermaid-editor.

tomoyukim avatar tomoyukim commented on June 18, 2024

Thank you for your report!
I couldn't reproduce it but could you try to check the place in which your config file is put once again? It must be the same directory as your mmd file when you describe ./config.json

from vscode-mermaid-editor.

aaulia avatar aaulia commented on June 18, 2024

image

As you can see from the screenshot, both files are on the same directory. But the preview still show the default theme. FWIW I also have few other extension for markdown and a couple other for mermaid (Markdown Preview Mermaid Support and Mermaid Markdown Syntax Highlighting) but AFAIK those shouldn't interfere with this extension's preview.

from vscode-mermaid-editor.

tomoyukim avatar tomoyukim commented on June 18, 2024

Thank you for quick response. Um, does the situation continue even when you edit .mmd file? I'm asking it because mermaid-editor only refresh the diagram when .mmd file is updated.
Or did you find any other operation to get out from the symptom?

from vscode-mermaid-editor.

aaulia avatar aaulia commented on June 18, 2024

The one I showed in the screenshot is something that I freshly made to demonstrate the issue. So since I start writing the mermaid file, it never uses the dark theme, ever. It's always use the default theme, despite the fact that I already set the theme to dark in the config.json.

from vscode-mermaid-editor.

robcresswell avatar robcresswell commented on June 18, 2024

I seem to be having the same issue. It doesn't actually bother me because I used "default" anyway, but let me know if there's anything you'd like me to help with or test to fix it

from vscode-mermaid-editor.

Pindar777 avatar Pindar777 commented on June 18, 2024

@tomoyukim I just found your VSC package and like it very much.
I'd like to add to the conversation that changing the background and the config-file just works via global settings. The "magic comments" instead have no effect at all.

from vscode-mermaid-editor.

Pindar777 avatar Pindar777 commented on June 18, 2024

@tomoyukim Update: All of a sudden even the global configuration has not effect anymore.
Here a png-file of a test that I created 4 days ago...with theme 'forest'.
mermaid_stateDiagram_forest

from vscode-mermaid-editor.

tomoyukim avatar tomoyukim commented on June 18, 2024

Thank you for your patience and help. I found an error parsing attributes in the document with CRLF. It was fixed in v 0.11.0 and please check it out!

from vscode-mermaid-editor.

Pindar777 avatar Pindar777 commented on June 18, 2024

@tomoyukim Thank you. Works like a charm.

from vscode-mermaid-editor.

robcresswell avatar robcresswell commented on June 18, 2024

@tomoyukim I'm not sure this is fixed. My setup is something like this:

.
├── .vscode
│   └── settings.json
└── src
    ├── config.json
    └── diagrams

diagrams is a directory with .mmd files, but its not really relevant here I think.

The settings.json looks like this:

{
  "mermaid-editor.preview.defaultMermaidConfig": "./src/config.json"
}

Even rendering a very trivial diagram such as

sequenceDiagram
  A ->>+ B: Foo
  B ->>- A: Bar

results in

Screenshot 2021-04-28 at 13 00 07

config.json is as follows:

{
  "theme": "dark",
  "deterministicIds": true
}

from vscode-mermaid-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.