Comments (2)
The macro is only invoked with [AsciiChar]
, [u8]
and str
, and is not exported.
So I don't think there's any actual "unsound usages".
Is the problem that the macro doesn't check that the type has the same size and alignment as AsciiStr
?
All the types it's used with are unsized, so std::mem::align_of::<$wider>()
won't compile, and even if it worked it wouldn't reject [bool]
which would also be unsound.
I can agree the macro has sharp edges though, and I'll accept a PR replacing widen_box!
with direct implementations.
from rust-ascii.
Yes, thanks for your reply! Since it's a static analysis, it would be an approximate of all the possibilities. If it's carefully used, there won't be issues.
from rust-ascii.
Related Issues (20)
- What is the intended behaviour of AsciiStr.lines()? HOT 2
- Implement `std::str::pattern::Pattern`
- Most functions could be const HOT 4
- Update quickcheck dependency to 0.8 HOT 7
- Publish next version to crate.io? HOT 1
- Implementing `From<&mut AsciiStr>` for `&mut str` and `&mut [u8]` is unsound HOT 8
- Mark AsciiStr `#[repr(transparent)]` ? HOT 2
- Versions 0.7.0-0.9.2 are yanked? HOT 1
- All files in crate are executables HOT 1
- AsciiChar::Caret documentation shows '_' HOT 1
- Easy way to get a &str or even just &AsciiStr out of [AsciiChar; _], &[AsciiChar; _] or &[AsciiChar] HOT 2
- AsciiChar::SOX should be AsciiChar::STX HOT 2
- Publish new version with the alloc feature? HOT 6
- Create `AsciiStr` from `str` using `const fn`
- Convert to and from AsciiString and Box<AsciiStr> HOT 1
- Benchmark HOT 2
- `serde_test` should be dev-dependency HOT 3
- Feature request: public iterator types
- Release new version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-ascii.