Giter VIP home page Giter VIP logo

Comments (2)

sbengo avatar sbengo commented on May 22, 2024

Hi @toni-moreno

I agree that API needs a refactor. I like the whole proposing changes, but I would like to split API functions into deeper levels according what is affecting to:

...

*********runtime related methods ****

/runtime/agent/reloadconf/  /api/rt/agent/reload
/runtime/snmpping/          /api/rt/agent/snmpping
/runtime/version/           /api/rt/agent/info/version
/runtime/info/              /api/rt/snmpdevice/info
/runtime/activatedev/       /api/rt/snmpdevice/status/activate
/runtime/deactivatedev/     /api/rt/snmpdevice/status/deactivate
/runtime/actsnmpdbg/        /api/rt/snmpdevice/debug/actsnmpdebug
/runtime/deactsnmpdbg/      /api/rt/snmpdevice/debug/deactsnmpdbg
/runtime/setloglevel/       /api/rt/snmpdevice/log/setloglevel
/runtime/getdevicelog       /api/rt/snmpdevice/log/getdevicelog
/runtime/forcefltupdate     /api/rt/snmpdevice/filter/forcefltupdate

from snmpcollector.

toni-moreno avatar toni-moreno commented on May 22, 2024

I like your suggestion but snmpdevice better renamed as "device" doing smaller urls, and snmp related renamed as "snmpconsole/XXXX"

In this scenario these could be the resulting API. ( updated with last new api)

@sbengo what do you think about?

******* Login methods **********
(no changes on these )
/login
/logout

*******Config related methods *****

/metric                     /api/cfg/metric
/measurement                /api/cfg/measurement
/measgroups                 /api/cfg/measgroup
/measfilters                /api/cfg/measfilters
/influxservers              /api/cfg/influxservers
/snmpdevice                 /api/cfg/snmpdevice

*********runtime related methods (agent related tools) ****

/runtime/agent/reloadconf/  /api/rt/agent/reload
/runtime/snmpping/          /api/rt/agent/snmpconsole/ping
/runtime/snmpquery/         /api/rt/agent/snmpconsole/query
/runtime/version/           /api/rt/agent/info/version

*********runtime related methods (device inspection related) ****

/runtime/info/              /api/rt/device/info
/runtime/activatedev/       /api/rt/device/status/activate
/runtime/deactivatedev/     /api/rt/device/status/deactivate
/runtime/actsnmpdbg/        /api/rt/device/debug/activate
/runtime/deactsnmpdbg/      /api/rt/device/debug/deactivate
/runtime/setloglevel/       /api/rt/device/log/setloglevel
/runtime/getdevicelog       /api/rt/device/log/getdevicelog
/runtime/forcefltupdate     /api/rt/device/filter/forcefltupdate

In a near future with a MIB database we can add new API url's on:

/api/rt/agent/mibdb/query

from snmpcollector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.