Giter VIP home page Giter VIP logo

Comments (5)

toonvanstrijp avatar toonvanstrijp commented on August 17, 2024 1

@jorgecoca I'm in the car right now but I'll write my opinion on this tonight or tomorrow ;)

I've thought about this and I think there are multiple ways to solve this problem and we need to discuss what solution is the best fit.

from nestjs-i18n.

toonvanstrijp avatar toonvanstrijp commented on August 17, 2024 1

@jorgecoca checkout the PR ;) let me know if this resolves your issue! :)

from nestjs-i18n.

toonvanstrijp avatar toonvanstrijp commented on August 17, 2024

@jorgecoca

I've looked into the reason why the resolve method has to return string | void and there is no reason why it should be like that :p.

So what we can do:

  • let the user define what the the resolve method should return by using generics

from nestjs-i18n.

jorgecoca avatar jorgecoca commented on August 17, 2024

Changes look good! Thank you so much!

from nestjs-i18n.

toonvanstrijp avatar toonvanstrijp commented on August 17, 2024

@jorgecoca update V4.0.6 is out! ;)

from nestjs-i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.