Allow protocol strings that do not end with colon ':' about node-socks-proxy-agent HOT 4 CLOSED

Closing because even ridiculous is what WHATWG URL does:

new URL('https://example.com')
URL {
  href: 'https://example.com/',
  origin: 'https://example.com',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'example.com',
  hostname: 'example.com',
  port: '',
  pathname: '/',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

from node-socks-proxy-agent.

The reason that it was implementing like that is because the result of url.parse() includes the :. PR welcome to support both formats though.

from node-socks-proxy-agent.

i agree, 'socks5:' is ridiculous, should just be 'socks5'

from node-socks-proxy-agent.

The best way is to support both types, like the issue creator said the object of protocol, host and port.
But also support for a simple string with the same value like: socks5://127.0.0.1:8182

from node-socks-proxy-agent.