Build failure with Qt built with -reduce-relocations about tora HOT 11 CLOSED

does it mean that the issue with qscintilla2 on gentoo was fixed?

from tora.

@ibre5041 yes, it is fixed (it is QScintilla[qt5] in the tree now)

from tora.

and, talking on topic of the issue, I am getting the same too, and have no idea about how to fix this... exporting -fPIC -DPIC to cflags doesn't help :(

from tora.

update: sed'ing -ggdb3 to -ggdb3 -fPIC in CMakeLists.txt fixed the problem.

// although, it will be nicer, if your buildsystem inherited system's C{,XX}FLAGS (that set in the environment)

from tora.

This is really turning into a nigtmare. I fixed it already several times. But I do not recall details.
It depends on cmake version. Some versions embed value of CMAKE_CXX_FLAGS_RELEASE in CMAKE_CXX_FLAGS - while others do not.

Some Qt versions set Qt5_POSITION_INDEPENDENT_CODE, therefore I tried to use CMAKE_POSITION_INDEPENDENT_CODE.

  # prevent error "You must build your code with position independent code if Qt was built with..
  #if (Qt5_POSITION_INDEPENDENT_CODE)
  #  SET(CMAKE_POSITION_INDEPENDENT_CODE ON)
  #endif()

But it was not supported on older cmake version. So I decided to use Qt5Widgets_EXECUTABLE_COMPILE_FLAGS. Theoretically this variable should contain flags, Qt was built with. Can you please check wheter your Qt installation sets this variable in .cmake files?

from tora.

So this:

  SET(CMAKE_CXX_FLAGS         "${CMAKE_CXX_FLAGS} ${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS}")
  SET(CMAKE_C_FLAGS           "${CMAKE_C_FLAGS}   ${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS}")
  STRING(TOUPPER "CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE}" _flags_var_name)
  SET(${_flags_var_name}      "${${_flags_var_name}} ${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS}")
  SET("CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE}" _flags_var_name)

Should add the proper flags to the current build type.

from tora.

Not sure about Widgets one:

$ grep -r COMPILE_FL /usr/lib64/cmake/Qt5Widgets/
/usr/lib64/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:    set(Qt5Widgets_EXECUTABLE_COMPILE_FLAGS "")
/usr/lib64/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:        list(APPEND Qt5Widgets_EXECUTABLE_COMPILE_FLAGS ${Qt5${_module_dep}_EXECUTABLE_COMPILE_FLAGS})
/usr/lib64/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:    list(REMOVE_DUPLICATES Qt5Widgets_EXECUTABLE_COMPILE_FLAGS)

But Core one seems to do the right thing:

/usr/lib64/cmake/Qt5Core/Qt5CoreConfigExtras.cmake:    set(Qt5Core_EXECUTABLE_COMPILE_FLAGS "-fPIC")

from tora.

And, by the way, why don't you just add -fPIC as is by default to C{,XX}FLAGS unrelated to how Qt is built? :)

from tora.

because some distros need -fPIE and some other need even more flags. You should really use the same flags Qt was built with.

from tora.

Try it now.

from tora.

from tora.