Giter VIP home page Giter VIP logo

Comments (4)

koraykv avatar koraykv commented on July 23, 2024

Because there are many nn modules that just expect a tensor. The default behaviour in nngraph is everything is a table of something. You can see here (https://github.com/torch/nngraph/blob/master/gmodule.lua#L171) that non-table inputs are put into a table. It made the logic in the in the rest of the system consistent to assume that every input is a table.

from nngraph.

fidlej avatar fidlej commented on July 23, 2024

An alternative consistent implementation could see everything as a nested table.
I.e., the input can be a tensor or a table with other tables or tensors.

from nngraph.

hughperkins avatar hughperkins commented on July 23, 2024

The inconsistency does make trying to understand gmodule.lua quite a lot more complicated than it might otherwise be. Lots of edge-cases and stuff. Would making the nn modules document what they expect as input help? Like:

function Linear:expectsTensor()
  return true
end

from nngraph.

koraykv avatar koraykv commented on July 23, 2024

I think we have resolved this offline already/

from nngraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.