serialization fails for double values when format = 'ascii' about torch7 HOT 9 CLOSED

wow, that's a big catch.

from torch7.

Bug is from THDiskFile.c line 308ish

Default print and scan precision of fscanf and fprint is 6 digits (actually there's no standard I think).

It's better if we use %a for fprintf and fscanf so that the results will be exact.

from torch7.

but I cant send in a simple pull request to fix this, because it would break existing saved files.
@andresy needs to create a new version for the serialization format.

from torch7.

I don't think ascii is appropriate for conserving precision. This could cause the size of exported files to explode. Isn't it better to use binary format if you want to conserve full precision? It is faster to read/write and much smaller file size.

from torch7.

Ascii is needed for cross-platform compatibility (see other issues wrt
torch's big-endian/little-endian incompatibility). Ascii can have exact
precision with the %a fprintf formatter without taking up too much space.

On Thu, Feb 27, 2014 at 4:07 PM, koray kavukcuoglu <[email protected]

wrote:

I don't think ascii is appropriate for conserving precision. This could
cause the size of exported files to explode. Isn't it better to use binary
format if you want to conserve full precision? It is faster to read/write
and much smaller file size.

Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-36229316
.

from torch7.

Note sure what to do here.

• I could augment the default precision with %g (or switch to %f) (but how much precision would that be?)
• I could add a method to set the default precision (infinite would be with %a)

from torch7.

%a would be ideal but it is not C89. So maybe increasing the precision a bit makes sense.

from torch7.

%f by default would be 6 digits I think unless you specify explicit number of digits to pick up for decimal and fractional parta

from torch7.

Increasing the precision is probably enough at this point. Maybe twice as much as we have now?

from torch7.