Tests failing about torch7 HOT 15 CLOSED

that is a little weird because I've been running the tests all day on trunk, and I see no issues. What OS/build/BLAS?

from torch7.

I also have problems installing on Ubuntu from scractch with EZ install. Seg fault due to OPenBLAS

from torch7.

I run Torch in a Lua env (no LuaJIT) so some errors might come from that, need to investigate.

This one line though is clearly wrong: [https://github.com/torch/torch7/blob/master/test/test.lua#L469](m2 not defined), it crashes on my side and should.

from torch7.

There are some global vars defined in this test.lua file (m2), so I guess going from LuaJIT to Lua these tests don't get executed in the same order. Pretty scary. These tests need some attention.

from torch7.

Ok I patched all my issues here. I suggest running tests with th -g to catch globals. Also not sure why the missing messages in asserts would work with luajit?

from torch7.

OK I'll run the tests with -g from now on, it is a Lil scary.
I've been running them pretty actively and we have a cont build, both on luajit, saw no issues.
Weird!

from torch7.

Cool. For info I had 5 failures, 1 due to this missing global var (I fixed it but not sure what the intent was there), all other 4 were due to missing "message" in assert calls.

from torch7.

Why are message required in lua and not luajit?

from torch7.

string.format('something = %s', nil)

works in LuaJIT
fails in Lua

On Fri, Nov 7, 2014 at 5:31 PM, Nicholas Léonard [email protected]
wrote:

Why are message required in lua and not luajit?

—
Reply to this email directly or view it on GitHub
#93 (comment).

from torch7.

Then string.format('something = %s', var or '') ?

from torch7.

Yep, should patch Tester.lua then.

On Fri, Nov 7, 2014 at 5:36 PM, Nicholas Léonard [email protected]
wrote:

Then string.format('something = %s', var or '') ?

—
Reply to this email directly or view it on GitHub
#93 (comment).

from torch7.

on it

from torch7.

thanks!

On Fri, Nov 7, 2014 at 5:41 PM, Nicholas Léonard [email protected]
wrote:

on it

—
Reply to this email directly or view it on GitHub
#93 (comment).

from torch7.

BTW @clementfarabet your last commits weren't associated to your github account. Probably due to non-ssh clone.

from torch7.

Oops, thanks for that!

On Fri, Nov 7, 2014 at 5:50 PM, Nicholas Léonard [email protected]
wrote:

BTW @clementfarabet https://github.com/clementfarabet your last commits
weren't associated to your github account. Probably due to non-ssh clone.

—
Reply to this email directly or view it on GitHub
#93 (comment).

from torch7.