Parsing of SUT messages can result in a MultipleDefinitions error about torxakis HOT 5 OPEN

A quick analysis shows that the problem is that transforming the string M("Up command") to torxakis is ambiguous.
The ambiguity is caused by:

TYPEDEF ITypes0 ::=
	M { v :: String }
ENDDEF

TYPEDEF OTypes0 ::=
	M { v :: String }
ENDDEF

I.e. two data types have the same constructor (name and argument).

imho TorXakis should be able to distinguish these two data types, since only OType is expected.

from torxakis.

Thanks for the quick answer. Changing the typedef works:

TYPEDEF OTypes0 ::=
	E { v :: String }
ENDDEF

TXS >> test 1000
TXS >>  .....1: IN: Act { { ( InSut0, [ M("Up pressed") ] ) } }
TXS >>  .....2: OUT: Act { { ( OutSut0, [ E("Up command") ] ) } }
TXS >>  .....3: IN: Act { { ( InSut0, [ M("Up pressed") ] ) } }
TXS >>  .....4: OUT: Act { { ( OutSut0, [ E("Up command") ] ) } }
TXS >>  .....5: IN: Act { { ( InSut0, [ M("Up pressed") ] ) } }

What should I do with the issue, close it?

from torxakis.

The function compileValExpr lacks a parameter to specify the expected type (when known).
This would disambiguate the value of the string and prevent the reported error.

@brampetersen lets keep the error open as a reminder to improve this!

from torxakis.

Changed title to better reflect isssue:
Parsing of SUT messages uses too little information: it doesn't use the expected type.
This lack of information can result in a MultipleDefinitions error as is shown in this issue!

from torxakis.

Note: In refactorAll branch is this problem absent, since

-- | 'TorXakis.Value.Value' from 'Data.Text.Text' conversion.
-- Expected 'TorXakis.Sort' of 'TorXakis.Value.Value' must be provided.
valueFromText :: SortContext c => c -> Sort -> Text -> Either Error Value

from torxakis.