Asio-gRPC seems to have TSAN warnings about asio-grpc HOT 8 CLOSED

You must either compile gRPC with TSAN enabled or set preprocessor variable GRPC_TSAN_SUPPRESSED. See also grpc/grpc#22325

from asio-grpc.

or set preprocessor variable GRPC_TSAN_SUPPRESSED

Where should I add this definition? I have added it to cmake preset but then I get

CMake Warning:
  Manually-specified variables were not used by the project:

    GRPC_TSAN_SUPPRESSED

Thanks.

from asio-grpc.

Preprocessor variable means to the compiler. E.g. gcc -DGRPC_TSAN_SUPPRESSED or in CMake

target_compile_definitions(your_app PUBLIC GRPC_TSAN_SUPPRESSED)

from asio-grpc.

I was expecting the to be able to put this only in our tsan preset not in cmake files for all presets.

from asio-grpc.

By the way, target_compile_definitions is not working. Do you think something like this will be needed?

from asio-grpc.

You are free to elevate the compile definition into a CMake variable. In my code I have this for example:

option(USE_SANITIZER "Compiles with sanitizer flags." off)

target_compile_definitions(grpc-objects PUBLIC "$<$<BOOL:${USE_SANITIZER}>:GRPC_TSAN_SUPPRESSED>"
                                               "$<$<BOOL:${USE_SANITIZER}>:GRPC_ASAN_SUPPRESSED>")

And then in CMakePresets.json:

    "configurePresets": [
        {
            "name": "local",
            "cacheVariables": {
                "USE_SANITIZER": true,

You must compile that all that includes gRPC files with those definitions, this includes the generated gRPC sources. I cannot try it myself at the moment, but doing it this way has always worked for me (haven't tested it with recent gRPC versions though). If you continue to see issues then you might need to create an issue at gRPC. Note that asio-grpc, has nothing to do with the data race, as you can see in the (abbreviated) logs:

SUMMARY: data race in grpc_event_engine::experimental::Epoll1Poller::DoEpollWait

from asio-grpc.

I have put it on my preset like this

"cacheVariables": {
                "CMAKE_CXX_FLAGS": "-fsanitize=thread -DGRPC_TSAN_SUPPRESSED"
            }

and can see it being passed to the compilation of all sources. But I still have the warnings.

But thanks you for your help.

from asio-grpc.

I cannot reproduce the issue even without setting GRPC_TSAN_SUPPRESSED using

• gcc 13.1.1
• gRPC 1.15.1 (compiled in RelWithDebInfo)
• asio-grpc v2.6.0
• streaming-server.cpp from the examples (compiled in Debug/Release with -g and -fsanitize=thread)

from asio-grpc.