Incorrect metadata query in getMetadataTriggers method of MetadataTriggerService about apex-recipes HOT 7 CLOSED

Welcome! 👋

Thank you for posting this issue. 🙇🏼‍♂️ We will come back to you latest within the next 48h (working days). Stay tuned!

from apex-recipes.

@matej-me when I execute the query, as written, it works just fine for me. Can you help me understand a bit more about what issues you're having with the query as written?

from apex-recipes.

@codefriar Sure.

In the Custom Metadata Query about, this.objType is obtained by the call

Trigger.new[0].getSObjectType().getDescribe().getName();

Let's assume this is a custom object called Visit. The code above will return "Visit__c".

Now, let's run the following metadata query, assuming we have two metadata entries, one for a standard Contact object, another for the custom Visit object

SELECT Class__c, Object__c
FROM Metadata_Driven_Trigger__mdt

The result will be the following.

The query as is currently will be matching "Visit__c" against "01I7a000000WWCg", because the Custom Metadata Entity Relationship field does not return a string with the API Name of the object when referenced directly.

Let's now add Object__r.QualifiedApiName in the query

Basically, the query will return nothing, because it will be matching the wrong data. It won't find an entry for our Trigger Handler class.

from apex-recipes.

@matej-me

Ok, see this is where I'm confused. Here's a simplified query I'm testing with.

SELECT Class__c
FROM Metadata_Driven_Trigger__mdt
WHERE
    Object__c = 'Account'
    AND Enabled__c = TRUE
ORDER BY Execution_Order__c

I run this in an org where Apex Recipes is installed and it correctly returns two rows:

Here's the Log:

sfdx force:data:soql:query --query SELECT Class__c FROM Metadata_Driven_Trigger__mdt WHERE     Object__c = 'Account'     AND Enabled__c = TRUE ORDER BY Execution_Order__c
Querying Data... done
CLASS__C
──────────────────────────────
MDTAccountTriggerHandler
MDTSecondAccountTriggerHandler
Total number of records retrieved: 2.

I've not tried this with other objects, and I'm not opposed to your proposed change, I just want to make sure I understand the problem first and from my testing ... I don't see a problem.

from apex-recipes.

@codefriar Try adding a Metadata_Driven_Trigger__mdt record for a custom object. This will recreate the issue.

from apex-recipes.

from apex-recipes.

Not a problem. Hope to have been of service.

from apex-recipes.