Work around Chef's double-linking bug in the neo4j-server recipe about travis-cookbooks HOT 10 CLOSED

I think I have this fixed in my PR (travis_user)

from travis-cookbooks.

Our cookbook shouldn't do anything with neo4j-shell. I suspect that neo4j user is not specified in node attributes, not sure why.

from travis-cookbooks.

I cannot reproduce this on 12.04. Are you sure you have up-to-date cookbooks and not overriding attributes? neo4j-shell should be available in 1.6 and any more recent version.

from travis-cookbooks.

I think I fixed this in my PR, I added a chef command to remove the link if the link existed, and then add it, which seems to help. I will try it once more today.

On 14/05/2012, at 6:53 AM, Michael Klishin wrote:

I cannot reproduce this on 12.04. Are you sure you have up-to-date cookbooks and not overriding attributes? neo4j-shell should be available in 1.6 and any more recent version.

---

Reply to this email directly or view it on GitHub:
#50 (comment)

from travis-cookbooks.

Then we need to just add a not_if rule to the link resource

from travis-cookbooks.

Same problem

from travis-cookbooks.

Due to a bug in Chef, link resource does not work as expected. I have a fix in a different (non-OSS) repo that will be ported to the canonical Neo4J Server Chef cookbook soon.

from travis-cookbooks.

Any chance you can share a diff of the fix or let us know what to change to make it work?

from travis-cookbooks.

Still getting an error:

[Mon, 16 Jul 2012 21:09:01 +0000] ERROR: link[/usr/local/bin/neo4j](neo4j-server::tarball line 105) has had an error
[Mon, 16 Jul 2012 21:09:01 +0000] ERROR: link[/usr/local/bin/neo4j](/tmp/vagrant-chef-1/chef-solo-1/cookbooks/neo4j-server/recipes/tarball.rb:105:in from_file') had an error: link[/usr/local/bin/neo4j](neo4j-server::tarball line 105) had an error: TypeError: can't convert nil into String /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/file_access_control/unix.rb:106:in stat'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/file_access_control/unix.rb:106:instat' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/file_access_control/unix.rb:61:in set_owner'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/file_access_control/unix.rb:30:inset_all' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/mixin/enforce_ownership_and_permissions.rb:33:in enforce_ownership_and_permissions'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/provider/link.rb:96:inaction_create' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource.rb:454:in send'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource.rb:454:inrun_action' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/runner.rb:49:in run_action'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/runner.rb:85:inconverge' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/runner.rb:85:in each'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/runner.rb:85:inconverge' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection.rb:94:in execute_each_resource'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:incall' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in call_iterator_block'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:instep' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in iterate'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:ineach_with_index' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/resource_collection.rb:92:in execute_each_resource'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/runner.rb:80:inconverge' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/client.rb:330:in converge'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/client.rb:163:inrun' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/application/solo.rb:207:in run_application'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/application/solo.rb:195:inloop' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/application/solo.rb:195:in run_application'
/opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/../lib/chef/application.rb:70:inrun' /opt/vagrant_ruby/lib/ruby/gems/1.8/gems/chef-0.10.10/bin/chef-solo:25 /opt/vagrant_ruby/bin/chef-solo:19:in load'
/opt/vagrant_ruby/bin/chef-solo:19
[Mon, 16 Jul 2012 21:09:01 +0000] ERROR: Running exception handlers
[Mon, 16 Jul 2012 21:09:01 +0000] ERROR: Exception handlers complete
[Mon, 16 Jul 2012 21:09:01 +0000] FATAL: Stacktrace dumped to /tmp/vagrant-chef-1/chef-stacktrace.out
[Mon, 16 Jul 2012 21:09:01 +0000] FATAL: TypeError: link[/usr/local/bin/neo4j](neo4j-server::tarball line 105) had an error: TypeError: can't convert nil into String

from travis-cookbooks.

@mikekhristo code around line 95 is

%w(neo4j neo4j-shell).each do |f|
  link "/usr/local/bin/#{f}" do
    owner node.neo4j.server.user
    group node.neo4j.server.user
    to    "#{node.neo4j.server.installation_dir}/bin/#{f}"
  end
end

which suggests that either node.neo4j.server.installation_dir or node.neo4j.server.user are nil. Check how you may be overriding node attributes. It is also a good idea to report issues for the cookbook itself and not travis-cookbooks.

from travis-cookbooks.