Giter VIP home page Giter VIP logo

Comments (2)

frsyuki avatar frsyuki commented on August 16, 2024

Digdag should have a background procedure that deletes old sessions periodically. it's not implemented but expected by design.

from digdag.

frsyuki avatar frsyuki commented on August 16, 2024

implementation idea 1:

  • add state_flags and obsolete_name to projects table.
  • make projects.name nullable.
  • when user deletes a project, digdag does following works in a single transaction:
    • copies name to obsolete_name.
    • set NULL to name.
    • set ProjectStateFlags.DELETED to state_flags.
    • delete all schedules associated to the project.
  • adding a new revision should be rejected if state_flags is DELETED (at ProjectControl.insert* methods because having ProjectControl ensures that the record is locked with FOR UPDATE).

This architecture makes it easy to have UNIQUE INDEX on name column. Looking up a project by name doesn't return logically deleted projects but looking up by id returns one. This is a naturally expected behavior.

Future plan 1:

  • add a background thread that does following work:
    • delete old sessions and session_attempts older than timestamp T at most N records
    • if number of deleted records is less than N, there're no sessions or session_attempts older than timestamp T. in this case, start deleting projects whose state_flags is DELETED and updated_at is older than T.
    • deleting project consists of following work:
      • delete task log files from storage
      • delete revision archive files from storage
      • delete workflow_configs using multiple transactions
      • delete workflow_definitions using multiple transactions
      • delete revisions using multiple transactions
      • delete project

from digdag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.