Giter VIP home page Giter VIP logo

Comments (15)

rajdip-b avatar rajdip-b commented on August 17, 2024 2

@severinlandolt hey, I feel I can fix this. Should I submit a PR?

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024 2

Hi @lucafaggianelli @rajdip-b @rlancejohnson! Brief update: The overflow problem still persists and it looks like that this won't be fixable soon. I will update this asap once there is a fixing headless ui release.

If you are in desperate need of a date picker with improved positioning, it's worth taking a look here: https://raw.tremor.so/docs/inputs/date-range-picker

CleanShot 2024-04-19 at 20 56 56@2x

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024 1

Good news: https://x.com/adamwathan/status/1729274129264624056?s=20

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024 1

Hi @rlancejohnson → still blocked! Waiting for headless ui 4.0.

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024

That would be great! I just assigned you. I have to go to sleep now🤣

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

That would be great! I just assigned you. I have to go to sleep now🤣

Would try to submit the PR by the time you wake up!🤣

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

Hey guys, I was experimenting with the component and sort of found it difficult to fix the alignment automatically. This is so because the Calendar is being rendered in an absolute component, which makes it very tricky to use flex boxes. I however, created a flag that will dock the calendar to left/right, thereby fixing the issue.

Here is a demo
image
image

Can anyone suggest any improvements? @severinlandolt @lucafaggianelli

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024

I've completed some tests and its basically a feature that our underlying library (headlessui) does not offer natively.
CleanShot 2023-11-20 at 01 01 12@2x

Thank you @rajdip-b for your initial effort and suggesting a new prop. We will do some thinking around that an come back later!

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

I've completed some tests and its basically a feature that our underlying library (headlessui) does not offer natively. CleanShot 2023-11-20 at 01 01 12@2x

Thank you @rajdip-b for your initial effort and suggesting a new prop. We will do some thinking around that an come back later!

Sure!!

from tremor.

lucafaggianelli avatar lucafaggianelli commented on August 17, 2024

Yep indeed I reached the same conclusion on headlessui. Though I saw you use the lib floating ui as well in tremor, which seems more suited for this task.

About the new property, maybe I would call it "anchor" or something similar to make it more flexible so it could have values like right, left, center for the horizontal alignment and top, bottom, middle for the vertical one, I see many libs using this pattern.

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

Yep indeed I reached the same conclusion on headlessui. Though I saw you use the lib floating ui as well in tremor, which seems more suited for this task.

About the new property, maybe I would call it "anchor" or something similar to make it more flexible so it could have values like right, left, center for the horizontal alignment and top, bottom, middle for the vertical one, I see many libs using this pattern.

Yeah even I did notice that. Should I proceed with the implementation, see what all changes I can implement? @lucafaggianelli @severinlandolt

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

Good news: https://x.com/adamwathan/status/1729274129264624056?s=20

I guess this issue can be closed then?

from tremor.

severinlandolt avatar severinlandolt commented on August 17, 2024

I will keep it open until Headless UI has been updated

from tremor.

rajdip-b avatar rajdip-b commented on August 17, 2024

Sure!

from tremor.

rlancejohnson avatar rlancejohnson commented on August 17, 2024

Any update on this?

from tremor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.