Giter VIP home page Giter VIP logo

Comments (10)

tsusanka avatar tsusanka commented on September 4, 2024 1

Let's finish this.

Thx to trezor/trezor-suite#5214 we are getting closer to make trezor/trezor-suite#4692 a reality and for that we need this one.

Upon further consideration I think we should push as much automation as possible. Let's deploy to S3 directly then. I have filed a PR explaining this: #39. @vdovhanych could you please review and then do the CI part in Suite?

from data.

tsusanka avatar tsusanka commented on September 4, 2024

@vdovhanych do you think you could do this when you have a sec? :) Only if it is a low-hanging fruit.

from data.

vdovhanych avatar vdovhanych commented on September 4, 2024

Will try to finish it today, btw will we want to commit the binaries to the data repository, no right ?

from data.

prusnak avatar prusnak commented on September 4, 2024

I already committed the binaries in 8051e34

from data.

vdovhanych avatar vdovhanych commented on September 4, 2024

I already committed the binaries in 8051e34

i meat suite app packages, sorry.

from data.

tsusanka avatar tsusanka commented on September 4, 2024

I mean we can do both: upload Suite to data.trezor.io and commit here. However in the original post I indeed meant only uploading to data.trezor.io as I am not sure committing them here gives us something. We have to do it manually and the source of truth for Suite are Github releases anyway. So what advantage does it have committing them here? Consistency is a fair point, but maybe that's it?

So basically, I am just not sure it is worth it. We could also in future migrate firmwares to Github releases..

from data.

tsusanka avatar tsusanka commented on September 4, 2024

Now that I think of it, maybe it would cause more harm than good having Suite on S3 but not here? And the best way to move forward is to simple add Suite binaries manually for now to have the S3 bucket consistent with this repo. And then rework it at some point in future. What do you think?

from data.

vdovhanych avatar vdovhanych commented on September 4, 2024

@tsusanka consistency only, it won't bring any advantage having it committed here. But at least the setup would be the same as is. Meaning we add binaries and packages here and then it gets deployed to s3.

from data.

vdovhanych avatar vdovhanych commented on September 4, 2024

Addressed here trezor/trezor-suite#5594

from data.

tsusanka avatar tsusanka commented on September 4, 2024

Ok, so this is not that simple as I thought (summary here). We will first discuss properly in trezor/trezor-suite#4692 and see what options there are.

I am closing this issue as we indeed are not sure what we actually want yet. We will reopen or make a new one then. Sorry for the fuzz!

from data.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.