Giter VIP home page Giter VIP logo

Comments (5)

prusnak avatar prusnak commented on July 30, 2024

If you think this is worth pursuing please send a pull request.

from python-trezor.

kyuupichan avatar kyuupichan commented on July 30, 2024

An example of why it's useful: your tx_api callback does not provide a self argument, because one is not needed. The problem is that if that tx_api wants to call expand_path (which it does), it suddenly needs a self argument to call it on. That is not good. It has to go from stateless to stateful.

from python-trezor.

prusnak avatar prusnak commented on July 30, 2024

Do you have a capacity to prepare the pull request?

from python-trezor.

kyuupichan avatar kyuupichan commented on July 30, 2024

Fair enough. I think it should work; I can't test it though. Electrum now uses a modified copy of this code; once KeepKey and Trezor libraries have supported a static one for a while I'd be happy to remove it and use the library one.

from python-trezor.

prusnak avatar prusnak commented on July 30, 2024

I merged the PR and will close this issue. If there are more, feel free to send another PR. Thank you!

from python-trezor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.