Comments (13)
Sure I will check it
from trino.
from trino.
@davseitsev could you try benchmarking your case with #22451 ?
There could be further improvements made, but I wanted to see if those changes are sufficient for your scenario.
from trino.
Now it's a little bit better.
![image](https://private-user-images.githubusercontent.com/1793410/341708379-abc7e517-7f44-4603-84b9-881948531cad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTU5MzAsIm5iZiI6MTcxOTE5NTYzMCwicGF0aCI6Ii8xNzkzNDEwLzM0MTcwODM3OS1hYmM3ZTUxNy03ZjQ0LTQ2MDMtODRiOS04ODE5NDg1MzFjYWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDIyMDMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzYyZTlkYjJhMTUwNDE3MGUxYjRhMTg0NDA5MWQ4NzY5N2U2MWU4NmNiNjJlNmQ0MGQ4YmI3NjQxMTgzNDYzNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rNh5bSFngNu1WECDlrAxGMWCC2jj5VnVwrmSVop-F6w)
In comparison to previous results I would say it's about 1.35x times better.
The flame graph looks similar:
from trino.
That still looks strange because I removed the usage of ColumnPath#get from getColumnChunkMetaData
, but it's still somehow showing in your flamegraph.
from trino.
I will check it
from trino.
Ok, it's my bad, I didn't deploy the change properly.
![image](https://private-user-images.githubusercontent.com/1793410/341738242-53b830f1-1a88-454b-8ab6-db5b03d49e1b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTU5MzAsIm5iZiI6MTcxOTE5NTYzMCwicGF0aCI6Ii8xNzkzNDEwLzM0MTczODI0Mi01M2I4MzBmMS0xYTg4LTQ1NGItOGFiNi1kYjViMDNkNDllMWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDIyMDMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTI1OGIxYWY2NmZkZmViNjE4ZDhkNTM4MzMzYjhhMDNlY2FhNDdmNTdlYTZjYjg2NzBkODY3M2Q2MTMzMTE4ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ED_yI8NuB8KIpBlfO9TXm190KHFK8SYqtKC-6b_iMW4)
![image](https://private-user-images.githubusercontent.com/1793410/341726725-c666e42b-8f39-44b1-8451-9233eb948d34.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTU5MzAsIm5iZiI6MTcxOTE5NTYzMCwicGF0aCI6Ii8xNzkzNDEwLzM0MTcyNjcyNS1jNjY2ZTQyYi04ZjM5LTQ0YjEtODQ1MS05MjMzZWI5NDhkMzQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDIyMDMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDRhOGZkODAwMTI4ZmZhMTEyYWZjZTEyZGNlNGQ1YzE2YWQwMDYxMTllZTVlODg2OTY0NDA5OGU0ZWU3ODE3ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.25sHsRDAwDxNC7DlrpEsUo6XE8fuTsQHYe6kbxwLZho)
from trino.
Okay, so we have improved significantly with the new changes but this needs further improvement still. Would you be able to share a sample file, table definition and test query with me so that I can assess potential optimizations more easily ?
from trino.
Related Issues (20)
- Delta Lake connector can create tables having different case fields in row types, but can't read it
- Feature-Request: Implement File Status Cache System Procedure
- Add support for `allowColumnDefaults` writer feature in Delta Lake connector
- Allow users to pass prometheus filters via config properties and session properties
- Bug in ST_Point docs
- ORDER BY caluse of INSERT INTO statement is unexpectantly eliminated HOT 1
- Add event-listener plugin with Kafka sink HOT 1
- Does trino support Microsoft AAD authentication with Access Token?
- Does trino support Azure AD authentication HOT 1
- Add support for more type widening in Delta Lake connector
- Flaky test `TestWorkerRestart.testStartDuringQuery`: "No factory for connector" HOT 2
- For each agg function with input param as <T>, Add an equivalent agg function with input param as array<T> HOT 1
- TestDeltaLakeLocalConcurrentWritesTest.testConcurrentInsertsReconciliationForMixedInserts flaky
- Trino data lake connectors categorize HDFS quota exceeded exceptions as EXTERNAL but should be USER_ERROR HOT 3
- Some queries running on RedShift connector will get stuck after a couple of executions
- mongodb not find column? HOT 1
- trying to connect hudi from trino HOT 1
- [ICEBRG] How to set write.object-storage.enabled property for table? HOT 1
- Insufficient Cache Control in admin UI page which contain user-supplied information HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trino.