Giter VIP home page Giter VIP logo

Comments (13)

davseitsev avatar davseitsev commented on June 30, 2024 1

Sure I will check it

from trino.

wendigo avatar wendigo commented on June 30, 2024

cc @raunaqmorarka

from trino.

raunaqmorarka avatar raunaqmorarka commented on June 30, 2024

@davseitsev could you try benchmarking your case with #22451 ?
There could be further improvements made, but I wanted to see if those changes are sufficient for your scenario.

from trino.

davseitsev avatar davseitsev commented on June 30, 2024

Now it's a little bit better.

image

In comparison to previous results I would say it's about 1.35x times better.

The flame graph looks similar:
image

from trino.

raunaqmorarka avatar raunaqmorarka commented on June 30, 2024

That still looks strange because I removed the usage of ColumnPath#get from getColumnChunkMetaData, but it's still somehow showing in your flamegraph.

from trino.

davseitsev avatar davseitsev commented on June 30, 2024

I will check it

from trino.

davseitsev avatar davseitsev commented on June 30, 2024

Ok, it's my bad, I didn't deploy the change properly.

image image

from trino.

raunaqmorarka avatar raunaqmorarka commented on June 30, 2024

Okay, so we have improved significantly with the new changes but this needs further improvement still. Would you be able to share a sample file, table definition and test query with me so that I can assess potential optimizations more easily ?

from trino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.