Comments (8)
Thanks! fixing this in SVN, I'm writing a regression test for the issue. I'm
curious,
did you spot it because of a crash on unknown command or looking at the source
code? :)
Original comment by [email protected]
on 19 Mar 2009 at 10:20
from redis.
It crashed when running the "Non existing command" test from the testsuite.
Original comment by [email protected]
on 19 Mar 2009 at 11:22
from redis.
ah ok, pretty strange that valgrind didn't reported this even running the full
'make
test' under valgrind, so it didn't fixed before. Btw now it's fixed under SVN.
Thanks
for the help. I'll probably release beta-9 tomorrow with just this fix since
it's a
bit critical if the server can crash with the standard test.
Original comment by [email protected]
on 19 Mar 2009 at 11:30
from redis.
I mean beta-8 :) not 9
Original comment by [email protected]
on 19 Mar 2009 at 11:31
from redis.
... which is pretty much the same as the test you just added.
I bet the original test worked for you by fluke because whatever happened to be
in
memory past the end of the array happened to be zeroes.
Original comment by [email protected]
on 19 Mar 2009 at 11:48
from redis.
Oh weird that valgrind didn't catch it.
Original comment by [email protected]
on 19 Mar 2009 at 11:49
from redis.
Yes sorry I removed the duplicated test, I added it by instinct since it was
out of
my mental scheme that there was already a test about it and still the bug was
there.
Now I removed the new test since it's absolutely useless. I'll close the bug
only
after beta-7 will be deprecated and beta-8 released. Thanks again.
Original comment by [email protected]
on 19 Mar 2009 at 11:54
from redis.
Original comment by [email protected]
on 22 Mar 2009 at 3:12
- Changed state: Verified
from redis.
Related Issues (20)
- BRPOPLPUSH return type is contingent on success HOT 2
- A 8G .aof file lead redis loading so slowly... HOT 3
- The command "config get databases" does not return
- Allow SORT Command to STORE results as sorted set HOT 1
- Even after flushall maxmemory shows the previous max value. HOT 10
- [FEATURE REQUEST]HMSETX/HSETX HOT 3
- BRPOPLPUSH and a single LPUSH with several items doesn't work well together HOT 2
- Suggestion on either using AOF or Save setting HOT 4
- [FEATURE REQUEST]maxmemory-policy HOT 4
- The issue about the special scenario in redis-2.2.12 HOT 5
- setex silent data loss when using unix time for expiration value HOT 4
- Need Git Tag for 2.2.13 HOT 1
- DBNUM Command HOT 4
- EXPIREAT make test fails
- Hello, antirez. At what time release b-tree version disk store? HOT 1
- make test error CentOS HOT 2
- Could not connect to Redis at 127.0.0.1:6379: Connection refused HOT 1
- configure bind two interface
- minor change (call to id instead of whoami) in install script HOT 1
- /
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redis.