Comments (5)
Hi @twest820
Thank you for finding this interesting issue. Indeed the manual of the 3-PG is declaring the number of days per month
.
However, if you look at the code itself (also of 3-PGpjs which can be downloaded here https://3pg.forestry.ubc.ca/software/) it will be recognised that the same formula as in r3PG
or 3PGmix
is used for the frost days, see below:
'calculate frost modifier
fFrost = 1 - kF * (FrostDays / 30)
Since we were translating the code and aimed to test compatibility it was done the same way as in the original model.
I fully support your suggestions for improvements. Please feel free to create a new branch an make a push request to incorporate the changes.
Unfortunately from my side there is very little time to allocate for it.
from r3pg.
Yeah, I know how that goes. Thanks Volodymyr, I'll address this in my branch but, as I'm not coding in Fortran, a pull request is unlikely to materialize. A daysInMonth(month)
lookup, as done elsewhere in the existing code, would address this. Modulo the leap year issue I'm about to capture, anyways.
from r3pg.
I'll address this in my branch but, as I'm not coding in Fortran
So is your intension to write model fully in R or other language? Would be great if you implement all your detailed comments and suggestions into the code!
from r3pg.
I think it's most accurate to say I'm looking into an experimental version for evaluating certain possibilities. Definitely not funded for anything like an R package though it's possible that, if things go well, the code might eventually become of wider interest. If that happens I'll follow up with you (most likely in email) but I anticipate it will be at least several months to find out, possibly well into next year.
from r3pg.
I have now implemented the number of days per month to calculate the f_frost
Line 88 in 40289a7
Additionally add the check to the prepare_climate
function to limit the frost_day
to the maximum possible
Line 100 in 40289a7
@DavidForrester this slightly however impacted the output of the model. Particularly it has deviated the biomass outputs by third digit for the stem biomass. The general pattern remain unchanged.
from r3pg.
Related Issues (20)
- Quarries regarding r3PG model HOT 3
- Order in morris plot in Vignette HOT 1
- Check - prepare_site prepare_species HOT 1
- Self-thinning/mortality HOT 1
- Premature end of simulation - No mortality, but are all trees dead? HOT 5
- release v0.1.4 HOT 14
- Soil class - Soil texture HOT 4
- gFortran error HOT 3
- why is e20 2.2? HOT 2
- get_parameters doesn't work HOT 5
- Strange biomass results in mixed forest HOT 3
- Spatial simulation for one specific output HOT 6
- GPP output analysis HOT 3
- Calibration in the vignette does not work HOT 19
- Warnings regarding the input data
- Further Developmen, Implementation and Documentation
- PKGNAME-package \alias
- Re-structure the package directory and include CI
- CRAN packages using integer(kind=) or real(kind=) with numerical values HOT 1
- Allometric parameterisation for Chestnut HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from r3pg.