Giter VIP home page Giter VIP logo

Comments (6)

troy351 avatar troy351 commented on May 29, 2024 3

I'll fix it next Monday :)

from emmet-monaco-es.

troy351 avatar troy351 commented on May 29, 2024 2

It seems the dist code of [email protected] mangled private and protected properties of class which was used inside this project microsoft/vscode-discussions#257 microsoft/vscode#166126.
I can somehow find the mangled property but it not seems promising.

from emmet-monaco-es.

troy351 avatar troy351 commented on May 29, 2024 1

v5.2.0 was release by switching to mangled property name, could be broken in next monaco-editor release

from emmet-monaco-es.

CetinSert avatar CetinSert commented on May 29, 2024

@troy351 – does monaco not expose enough documented APIs to implement emmet without access to private/protected members?

from emmet-monaco-es.

CetinSert avatar CetinSert commented on May 29, 2024

microsoft/vscode-discussions#257 (comment)

we do have source map information for mangled properties and anyone can use those to reverse map the non-mangled names. Fundamentally, patching VS Code is still possible it just got harder because names are shortened (for the reasons outlined above). Generally, extension relying on patching internals are tolerated but not supported. Doing so would put us into a position where absolutely no change is possible anymore. Future engineering work, like the upcoming AMD to ESM migration, can cause a similar swirl and we will not pause them.

from emmet-monaco-es.

troy351 avatar troy351 commented on May 29, 2024

In order to trigger emmet at the correct location, token information was needed. And internal api was used to get token in a performant way. Public api can only tokenize whole file which is very slow in large files.

from emmet-monaco-es.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.