Options via data attributes about ajax-bootstrap-select HOT 10 CLOSED

@Rash96 sorry i haven't responded will try and take a look at this, this weekend.

from ajax-bootstrap-select.

@truckingsim Thank you

from ajax-bootstrap-select.

@Rash96 I just pushed up a fix and rebuilt the dist file. Can you take the dist file in the master branch and give it a shot? If it works I'll do a new release with that fix.

from ajax-bootstrap-select.

@truckingsim, the commit seems like a hack for jQuery < 1.6 (which introduced camelCasing data keys).

There is already code below what was committed that (should have) handled the overrides automatically: 9d889a8#diff-363cba4658af6719eba371f4899de525R243

from ajax-bootstrap-select.

Also, why was this bumped to 1.4.0? Isn't this just a bug fix?

from ajax-bootstrap-select.

I bumped it to 1.4.0 because I felt like it changed how the keys were handled. Even though it fixes it I felt like it had the possibility to possibly change expected behaiviour for someone. So I decided to do a minor version bump, that can be changed easily though since i haven't actually done a tag.

Also this fixes the data attributes not working. It wasn't about loading in a different locale through a file, or even using the locale option when instantiating the instance through .ajaxSelectPicker(). The data attribute was broke, even in jQuery 1.9. It was happening in our index.php example file with his example.

from ajax-bootstrap-select.

I see what you're talking about now (about this issue). I think we can do a patch version bump instead, it shouldn't affect anything (as it's not really working in the first place).

In an effort to work with the existing code, I took a look at how the data attributes are expanded into the options object in the first place. I'd much prefer to introduce a flattenedOptions array that will automatically squash the options as needed (in this case, locale).

I'll commit shortly.

from ajax-bootstrap-select.

@truckingsim, finished with the commit and build, let me know what you think.

from ajax-bootstrap-select.

Like your solution much better. Thanks for cleaning that up. @Rash96 give it a try but I'm going to do a full release. I'm confident this is fixed.

from ajax-bootstrap-select.

@truckingsim, I have checked, it works now. Thank you!

from ajax-bootstrap-select.