<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Remove reliance on web3 solidity-coder about truffle-core HOT 3 CLOSED

trufflesuite commented on August 29, 2024

Remove reliance on web3 solidity-coder

from truffle-core.

Comments (3)

jtakalai commented on August 29, 2024

web3 has those log decoding things exposed in web3.eth.abi without importing stuff.

Our current (pre-1.0) code has

const SolidityEvent = require("web3/lib/web3/event.js")
const SolidityCoder = require("web3/lib/solidity/coder.js")

and then does lots of log parsing from ABI, core lines being

        // TODO: probably should handle somehow "If arrays (including string and bytes) are used as indexed arguments, the Keccak-256 hash of it is stored as topic instead." (http://solidity.readthedocs.io/en/develop/contracts.html#events)
        const paramTypes = event.inputs.filter(i => !i.indexed).map(i => i.type)
        const paramBytes = log.data.replace("0x", "")   // unindexed params go into data
        const paramValues = SolidityCoder.decodeParams(paramTypes, paramBytes)

but also noticing in comments

        /* web3.js 1.0 (remove direct SolidityCoder/SolidityEvent refs)
        // for anonymous events, const paramValues = web3.eth.abi.decodeLog(event.inputs, log.data, log.topics)
        const paramValues = web3.eth.abi.decodeLog(event.inputs, log.data, log.topics.slice(1))
        */

So yeah, I think web3.js 1.0 will greatly simplify log parsing, and that's really one of the big features I've been waiting to have from it. It's not so great to have to import stuff from the "internals".

from truffle-core.