Comments (5)
trungvose
commented on July 30, 2024
Thanks @bryar1991 for reporting it. It was indeed a bug.
You're right, I don't store the sound state on localStorage. But upon start a new game/game over, if you turn off the sound. It should stay off. At the moment, I always bring back the sound on when you restart the new game. I will do a quick fix for that.
To store it along with some other state on the localStorage, I will do it later together with the offline feature 🥰 Will keep you posted.
from angular-tetris.
trungvose
commented on July 30, 2024
@bryar1991 I fixed this bug. Now the if the sound is turned off, it will be off until you refresh the browser 🍻 See the screenshot. Please verify and let me know your thought.
from angular-tetris.
bryar1991
commented on July 30, 2024
@trungk18 I checked your solution which is at feature/pwa branch and it's working as you have described.
Thanks a lot :)
from angular-tetris.
Awab-fedail
commented on July 30, 2024
On Sat, 29 Aug 2020 at 7:14 PM Bryar ***@***.***> wrote:
Closed #10 <#10>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQMXNMZTGXY67PYRF4Y6UY3SDEZRBANCNFSM4QORGU2Q>
.
I think you mean someone else😅😅
from angular-tetris.
trungvose
commented on July 30, 2024
Cheers 🍻🍻🍻
from angular-tetris.
Related Issues (10)
- Pause button label not getting updated
- Encapsulate Query Objects access HOT 1
- New Feature: Hold piece HOT 2
- i have downloaded the source code but it is not running and showing white screen... so, can you tell me how to fix it?? HOT 1
- cant open
- cant run
- Doesn't really work on mobile, browser was confused between click event and the zoom in of the mobile gesture HOT 1
- After playing a while, when i lose. the game restarts in the middle of another game. With lots of squares filled.
- Sounds is not working - Reported by @wannabe_tecky
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-tetris.