Clang-tidy doesn't work from VSCode about plugins HOT 12 CLOSED

Hi!

Thank you for trying Trunk!

I will need a bit more information to help you out. Can you tell me how you are generating the compile_commands.json?

from plugins.

just pass -D CMAKE_EXPORT_COMPILE_COMMANDS=ON in CMake.

CMake cersion is 3.27.4

File format like:

[
{
"directory": "/path/to/build/dir",
"command": "/path/to/compiler arguments contains -DGIT_TAG\\\"tag-name-commit-hash\\\"",
"file": "/path/to/file",
"output": "/path/to/object/file"
},
{
...
}
]

I think problem may be in -DGIT_TAG\\\"tag-name-commit-hash\\\", but Trunk do not print me any detailed information about exception

from plugins.

Hey, thanks for the quick response.

In your directory, there should be a .trunk/logs folder, would you be able to send me those?

Either added as a zip here, or maybe as a direct message through our community slack?
(Patrice Boisclair-Laberge in trunkcommunity.slack.com)

from plugins.

logs.zip

It floods about duplicates, but compile_commands.json do not have duplicates, maybe it read compile commands from subfolders? I have different folders in workspace/build for different platforms and copy compile commands for selected platform to workspace/build directory

from plugins.

Hi @sr-tream,
Can you please check if any of your compile_commands.json has a json number set for any of the directory, file, or command fields (ie, 7, but not "7")?

from plugins.

Don't have, and clang-tidy runned manually works fine

from plugins.

We've created a test build that may help with this issue. Can you please edit your .trunk/trunk.yaml and change the cli version to 1.15.1-beta.10 and see if that resolves the issues. After trying, could you also check your .trunk/logs/*.log and see if the string Skipping compile command shows up anywhere?

from plugins.

logs.zip

1.15.1-beta.10

With this version all works, and instead of exception print warning to logs

from plugins.

I see what the problem it, we'll get a fix out this week. Thanks for reporting this!

from plugins.

Also bugged underline. It starts from issue and ends at line end

from plugins.

This should be fixed in the latest version of trunk. Please let us know if that works for you.

from plugins.

Yes, its work now

from plugins.