[WIP] Define information for each coin about wallet-core HOT 5 CLOSED

@alejandro-isaza, @hewigovens what's the best way to configure chain ID? it could be Int or String

Would it make sense to have such struct:

struct ChainID {
     struct Ethereum {
        static let mainnet = 1
     }
     struct Wanchain {
        static let mainnet = 1
     }
     struct Binance {
        static let mainnet = "Binance-Chain"
     }
    struct Stellar {
         static let mainnet = "Stellar-Network"
         static let kin = "Kin-Chain"
    }
}

@alejandro-isaza C++ wise, what's the easier to make this work and generate code for it?

from wallet-core.

how about just do:

extension CoinType {
    var chainId: Int 
    var chainIdString: String
}

from wallet-core.

We can also just use string for everything. The alternative is to use std::variant<int, std::string> but we can't expose that on the interface.

from wallet-core.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from wallet-core.

Better design to avoid hardcoding and getting chain ID from the network itself.

from wallet-core.