Giter VIP home page Giter VIP logo

Comments (11)

ErisDS avatar ErisDS commented on May 22, 2024

If you like.. can get David to update his PR and I've not made the changes Ghost-side yet.
The only thing to keep in mind is that for the moment, it basically contains any and all settings from the settings table, although I intend to set a type.. which could be "blog" and then only provide settings of type blog to the theme.

from casper.

JohnONolan avatar JohnONolan commented on May 22, 2024

can we hold till tomorrow? (or update again tomorrow) - don't have a spare sec atm to go over

from casper.

cobbspur avatar cobbspur commented on May 22, 2024

just let know when and what you want it to changed to... this i think i can handle lol

from casper.

JohnONolan avatar JohnONolan commented on May 22, 2024

@ErisDS Right - tell me more about this "type" thing?

from casper.

ErisDS avatar ErisDS commented on May 22, 2024

So far settings have been key-value pairs. This is great but you end up with one big blob of stuff, and not all the settings are related.
I wanted to introduce a type field, so all settings are key-value grouped by type. It's a little more fiddly in some ways, but I think more powerful in others.

So, title, description, logo etc, all that would get a type of "blog"
Version, and other app fundamentals get a type of "core"
Stuff to do with plugins and themes might be "external" (this is not settings set by 3rd party plugins - thinking of having a separate table entirely for these)

from casper.

JohnONolan avatar JohnONolan commented on May 22, 2024

To clarify my understanding - 2 examples would be...

{blog.title} and {core.version} - right?

from casper.

ErisDS avatar ErisDS commented on May 22, 2024

Something like that yep

from casper.

JohnONolan avatar JohnONolan commented on May 22, 2024

That's fine with me - so what do you want to do with this issue?

from casper.

ErisDS avatar ErisDS commented on May 22, 2024

Updated & assigned.

from casper.

cobbspur avatar cobbspur commented on May 22, 2024

so is this issue still open or you want to add the blog and core naming system, is there going to be a new type field ?

from casper.

ErisDS avatar ErisDS commented on May 22, 2024

It requires/ is waiting on TryGhost/Ghost#172

from casper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.