Giter VIP home page Giter VIP logo

Comments (2)

kirrg001 avatar kirrg001 commented on July 28, 2024

The API JSON format is a bit different from the error instance format, which is also fine. They can be different.

API v2 JSON Format

message: ...
context: ...
type: ...
details: ...
help: ...
code: ...
id: ...

Error instance format

message: ...
context: ...
errorType: ...
errorDetails: ...
help: ...
code: ...
id: ...
level: ...
name: ...
  • has more properties
  • has partially different field names
  • would not be equal with our documentation

We probably have to keep the format of the JSON API if we deserialize the JSON response into a proper error instance. Questionable if we should use Ignition at all here 🤔

from sdk.

kirrg001 avatar kirrg001 commented on July 28, 2024

I won't use Ignition for now, because i don't see any benefit currently.

I will just add a catch handler and return a proper error instance and keep the JSON format from the API v2.

I will add an error handler for both content & admin API, otherwise it's inconsistent.

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.