Re-think Error Design about sdk HOT 2 OPEN

One thing I've run into which trolled me hard for a while was .response being deleted from the error thrown by makeRequest.

I was throwing custom errors from our overridden makeRequest function and was attaching the request as I needed conditional logic based on the response status code. Spent ages trying to work out why my response object wasn't available on the error without thinking to check that this package could be modifying errors rather than simply passing them through (I didn't actually get that far, I ended up renaming .request to .res assuming it was some weird zapier-cli quirk 🙈).

Does it make more sense to pass errors through as-is in this library and leave it up to the consumer's error handling/logging to do what it needs to do?

from sdk.

Does it make more sense to pass errors through as-is in this library and leave it up to the consumer's error handling/logging to do what it needs to do?

I think this is the best thing to do - and lines up with exposing primitives task

from sdk.