KO FlexGrid about kickoff HOT 11 CLOSED

Have done much more conclusive testing now – the new flexbox grid is running in production on JE now, and has been tested on pretty much everything I can think of.

Am currently moving the docs and test cases out of Kickoff main repo and into the docs site. Hoping to get this finished in the next couple of days. The grid should be ready to update in the generator now too though as it’s not going to change now barring any small tweaks resulting from any bug fixes 🚀

from kickoff.

I’ve now added and tested the grid on JE – not a conclusive test, but it works well in IE8/9/10/11, Firefox and Chrome, as well as mobile browsers.

Going to move on to working on the docs next week now – should be able to do them and setup a bunch of use cases that can be tested then as well. I’m happy with where the functionality is atm though 👍

from kickoff.

That's good too :)

from kickoff.

Small update – I’ve implemented the new grid system as a branch on the JUST EAT Platform, as it should be a good test of it’s base functionality.

I’m currently testing this over the next couple of days and then should be able to get started on the docs and generator updates.

from kickoff.

@ashleynolan that's awesome! Do you have a link for where its being used on JE?

Do you think we ought to make it its own repo?

from kickoff.

I was thinking about that, yeh. Is there anyway we can automatically pull it back into kickoff if we do that (I’ve never used git modules so not sure if this would be a use case for them…).

It’s used in a few places on the homepage of the international sites (so Canada for example) as well as on all the account pages (although you need to login to see them!). It will be on the search results and menu pages soon as well when I get chance to update them 👍

from kickoff.

Do you mean git submodules? If so I think they're quite a pain in the arse. I have looked into this sort of thing in the past because I wanted a better way to update the generator since most of the time the scss folder is copied straight to the generator. I created https://github.com/TryKickoff/scss for just this purpose, so it could be shared with the generator and the main repo and be installed via npm if need be.. If anyone reading this know how to achieve this, we would love some input. 🙏

from kickoff.

Yeh, that’s what I was thinking as well – never had chance to actually look into it properly but always is a pain having to update in multiple places.

from kickoff.

@ashleynolan what do you think the generator question should be? we currently ask if <=IE8 needs to be supported, should we ask is IE9 should be too?

from kickoff.

Generator for the flex-grid? I guess "Would you like to provide fallback classes for non-flexbox supported browsers?"

Does that sound ok?

from kickoff.

That's good, but I though this might be better:

Provide Flexbox feature-detect? Needed if you use our grid in non-flexbox supporting browsers

from kickoff.