Giter VIP home page Giter VIP logo

Comments (4)

Romakita avatar Romakita commented on July 16, 2024

ok, the serialization is run before the response filter.

  async flush($ctx: PlatformContext) {
    const {response} = $ctx;

    if (!$ctx.isDone()) {
      let data = await this.responseFilter.serialize($ctx.data, $ctx as any);
      data = await this.responseFilter.transform(data, $ctx as any);
      response.body(data);
    }
  }

https://github.com/tsedio/tsed/blob/production/packages/platform/common/src/services/PlatformHandler.ts

your code is wrong because it work on the $ctx.data and not over the data itself. it's not a bug you choose to work on the $ctx.data.

I should even make a fix to prevent you from using $ctx.data, as the devs don't do bad implementations in the response filter ^^.

Two solution:

  1. make transformation over data, just use $ctx.data to dermine if it's a Page instance, but apply url on data
  2. Inject PlatformResponseFilter and call serialize method, but, it's much less efficient to do that.

I close this issue
See you

from tsed.

github-actions avatar github-actions commented on July 16, 2024

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

github opencollective

from tsed.

Romakita avatar Romakita commented on July 16, 2024

I'll update the pagination to clarify this issue ;)

from tsed.

Romakita avatar Romakita commented on July 16, 2024

#2556

from tsed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.