Feedback on part 12 about tcod_tutorial_v2 HOT 3 OPEN

I agree that this could be better, but it's not clear if the data should be preprocessed by a function or if a new class should be made to encapsulate the data.

Did you have any code examples on your own project or is this just speculation so far?

from tcod_tutorial_v2.

I haven't actually written any code based on the tutorial; this is just based on my thoughts from reading it. In the simplest case the data is entered into the source code already in the correct format. To reduce the risk of human error, I think it would make sense to create a class to hold the configuration data and sort it in the constructor (or after loading it from a file or whatever way it is that the data gets into the class).

I could do a quick fork and create a pull request if you think that would be useful.

from tcod_tutorial_v2.

I'm not sure. If you want to do a pull request then make sure you start from the part-12 branch.

Ideally a new solution should be more readable then the current one. The performance for this section is not critical so I don't think the redundant calls to get_max_value_for_floor are a problem unless they affect readability.

from tcod_tutorial_v2.