Giter VIP home page Giter VIP logo

Comments (14)

tsujan avatar tsujan commented on August 15, 2024

I use this rules file for making a deb package that contains both plugins for Debian: https://dl.dropboxusercontent.com/u/7793460/rules
By contrast, most package maintainers (deb, rpm, arch) prefer separate packages for Qt4 and Qt5.

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

Oh, you mean something like cmake. It occurred to me but I've always preferred qmake over cmake. However, I'll think about it.

from kvantum.

KottV avatar KottV commented on August 15, 2024

Let me explain why i put this issue :)
rpm cannot have two build sections in spec file (macros for build and packaging), so i have to prepare two different package build sets, that's not critical, but inconvenient a bit

from kvantum.

KottV avatar KottV commented on August 15, 2024

but, in single spec very possible to separate compiled and installed files with dependencies in different packages

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

rpm cannot have two build sections in spec file...

Are you sure about that? I thought the same thing about deb but it turned out to be wrong after I experimented with the rules file (the counterpart of spec file). That was the reason I added a link above.
For now I have no rpm based system to test but I may install one on VirtualBox when I have free time.

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

To be more specific, I added the Qt5 build/installation AFTER the Qt4 one and apparently in the installation section of the rules file. And that worked. distclean was an asset.

from kvantum.

KottV avatar KottV commented on August 15, 2024

I did a dirty hack to workaround. Put make install (qmake, make, make install, make distclean, qmake-qt5, make, make install) in %build section and leave %install section empty. On local machine that's worked:)
Will try on build server later. But, I still think it's not nice way :)

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

I'd call that an elegant innovation instead of a "dirty hack" ;)
However, I'll try to add a cmake file as I don't think cmake and qmake are mutually exclusive.

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

I'm working on CMakeLists files but that alone would make no difference for packaging unless Kvantum is divided into two separate directories, one for Qt4 and the other for Qt5 (like in QtCurve). That division is something I've avoided from start.

As far as I see, the distclean trick in the rules/spec file is the best approach but if you know of a better one (without separate Qt4 and Qt5 branches), please tell me.

from kvantum.

KottV avatar KottV commented on August 15, 2024

Well. I think, no one will kill me, if i use such trick in build service. So, there the packages for openSUSE: http://software.opensuse.org/package/kvantum

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

OK. Just a suggestion: The doc folder in the source (containing documentation on theme config and theme making) could go to the doc installation folder.

After reading the spec file decription section, I realized that I shouldn't have referred to QuantumStyle when describing Kvanum in README. I'll change that later. This is the description I use in the deb package:

Kvantum is an SVG-based theme engine for Qt4/Qt5 and KDE. It has a default dark theme but goes far beyond it: you could make themes with very different looks and feels for it and Kvantum will let you control almost every aspect of Qt widgets.

from kvantum.

KottV avatar KottV commented on August 15, 2024

I added extra documentation to -doc package and changed description

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

Excellent!

from kvantum.

tsujan avatar tsujan commented on August 15, 2024

CMake support is added (mainly for Fedora, that has problem with qmake). Closing this.

from kvantum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.